Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OF-2134: Add option to enable certificate revocation checks #2610

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Commits on Nov 20, 2024

  1. feat: Add option to enable certificate revocation checks

    When enabled, certificates will be verified against Certificate Revocation Lists (CRL) and through Online Certificate Status Protocol (OCSP) to ensure they have not been revoked.
    viv committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    8d8afff View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ca563c9 View commit details
    Browse the repository at this point in the history
  3. feat: Configure OCSP

    - Permit client-driven OCSP (has no effect unless revocation checking is also enabled) by adding property to java.security settings.
    - Enable OCSP stapling by specifying jdk.tls.server.enableStatusRequestExtension=true Java system property.
    
    With this default configuration:
    
    - as a client: Openfire will behave in the same way as it did prior to this commit.
    - as a server: Openfire will staple OCSP responses when presenting its certificate if the certificate is configured with an OCSP responder and Openfire receives a response from the listed responder, otherwise the certificate will be presented with no OCSP response (the default behaviour prior to this commit).
    
    For further configuration options see: https://docs.oracle.com/en/java/javase/17/security/java-secure-socket-extension-jsse-reference-guide.html#GUID-527BAE97-3B78-4390-A479-623BD998C4EE
    viv committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    cd751b1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    42de835 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. fix: Don't send error stanza for TLS handshake failures

    Prior to this change, if the TLS handshake failed (e.g. if certificate validation did not succeed), an error stanza would be returned to the TLS client with the misleading message "An error occurred in XMPP Decoder".
    viv committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    662c569 View commit details
    Browse the repository at this point in the history
  2. feat: Add notice when revocation is enabled but client-driven OCSP is…

    … not
    
    If Openfire is configured to do revocation checking, but Java is configured to not support client-driven OCSP checking, we now inform the user.
    viv committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    a2e3af5 View commit details
    Browse the repository at this point in the history