Ifarchive-tuid-report: normalize urls #346
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salty-horse
reviewed
Oct 2, 2024
| $row = mysqli_fetch_row($result); | ||
| if (!$row) { | ||
| // normalize the path using URL normalizer. First we make it an absolute URL, normalize it, then we strip the absolute part off | ||
| $path = substr((new URL\Normalizer("https://ifarchive.org/$path"))->normalize(), strlen("https://ifarchive.org/")); |
There was a problem hiding this comment.
I would put https://ifarchive.org/ in a variable since it's used twice, and explicitly required to be identical for this "get suffix" technique.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required me to add composer support, but I struggled with it mightily. I'm not at all sure I'm handling that the "right way."
I'm checking in the
vendordirectory. There's some debate online about whether that's the "right way," but it means that other developers won't have to runcomposer, which is maybe a good thing.To facilitate this, I've set up some scripts that allow me to install
composerin the Docker instance, runcomposerthere, then clean up, (so we don't expose ourcomposer.jsonorcomposer.lockfile publicly).