Add a TODO to remove eval

ifad · Apr 21, 2024 · a938e65 · a938e65
1 parent 27c1df4
commit a938e65
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 13 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
diff --git a/lib/sharepoint/client.rb b/lib/sharepoint/client.rb
@@ -607,11 +607,14 @@ def uri_unescape(uri)
       URI::DEFAULT_PARSER.unescape(uri.gsub('%5B', '[').gsub('%5D', ']'))
     end
 
+    # TODO: Try to remove `eval` from this method. Otherwise, fix offenses
+    # rubocop:disable Security/Eval, Style/DocumentDynamicEvalDefinition, Style/EvalWithLocation, Style/PercentLiteralDelimiters
     def string_unescape(s)
       s.gsub!(/\\(?:[abfnrtv])/, '') # remove control chars
       s.gsub!('"', '\"') # escape double quotes
       eval %Q{"#{s}"}
     end
+    # rubocop:enable Security/Eval, Style/DocumentDynamicEvalDefinition, Style/EvalWithLocation, Style/PercentLiteralDelimiters
 
     def utf8_encode(s)
       s.force_encoding('UTF-8') unless s.nil?