Tweak how options[:temporal] is handled #97
+178
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this project has begun to be maintained again, so I've merged upstream master. If this PR is still useful would it be possible to get it in the next release? |
tagliala
reviewed
Nov 25, 2021
|
Hi, same considerations as the other PR. Any chance to rebase instead of merge and provide a failing test case? |
…tate in the case of a user manually managing "search_path"
pnomolos
force-pushed
the
pnomolos/better_transparency_for_temporalness
branch
from
4ab3d25 to
6a2aa61
Compare
|
@tagliala I've finally come back to this, including adding specs and reworking some functionality. I hope it's good to go now, please let me know if you'd like any further changes |
|
Hi @pnomolos, Just a heads-up to say thanks because I've cherry-picked some of these commits and merged them into master to fix an issue with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still need to write specs for this, but it changes how
options[:temporal]is handled so that if you don't pass anything explicit it'll work fine (rather than right now, where if you don't specifytemporal: trueon a chronomodel-handled table it'll return it to a plain table).