YANG updates for the -05 version #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to support multi-layer topology instances (ietf-ccamp-wg#5) Fixed YANG model prefix (ietf-ccamp-wg#3) Aligned with TE bandwidth, label range and label augmentations in other topology models Fixed other YANG language nits.
italobusi
commented
Sep 9, 2023
Comment on lines
+293
to
+299
| must ". = 'false' or " | ||
| + "../../vlan-tag-classification = 'true'" { | ||
| description | ||
| "VLAN service classification based on the second | ||
| VLAN tag can be supported only when VLAN service | ||
| classification"; | ||
| } |
There was a problem hiding this comment.
Need to check (testing some JSON examples) the correctness of this must statement
italobusi
added a commit
to italobusi/draft-ietf-ccamp-eth-client-te-topo-yang
that referenced
this pull request
Sep 12, 2023
Updated Xufeng affiliation Added Chaode as author Updated abstract and introduction to clarify the scope of the draft: fix ietf-ccamp-wg#1 Restructured sections 2, 3 and 4 Clarified that TE bandwidth and label augmentations are based on the guidelines in section 6 of RFC8795: see ietf-ccamp-wg#2 Removed section 5: see ietf-ccamp-wg#2 Aligned with latest YANG model: see PR ietf-ccamp-wg#6 Updated list of authors and contributors
aguoietf
reviewed
Sep 12, 2023
|
e-error.out.txt e.json.txt contains a small instance example that passes validation with yanglint |
aguoietf
approved these changes
Sep 12, 2023
samans
approved these changes
Sep 12, 2023
sergiobelotti
approved these changes
Sep 21, 2023
italobusi
added a commit
that referenced
this pull request
Sep 28, 2023
* Draft converted to kramdown Updated Xufeng affiliation Added Chaode as author Updated abstract and introduction to clarify the scope of the draft: fix #1 Restructured sections 2, 3 and 4 Clarified that TE bandwidth and label augmentations are based on the guidelines in section 6 of RFC8795: see #2 Removed section 5: see #2 Aligned with latest YANG model: see PR #6 Updated list of authors and contributors Updated reference to G.8021 Updated revision number Updated category to Standard Track
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to support multi-layer topology instances: fix #5
Fixed YANG model prefix: fix #3
Added references when applicable: see #2
Removed all the YANG statements comments out: see #2
Aligned with TE bandwidth, label range and label augmentations in other topology models
Fixed other YANG language nits.