Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To/#610 extend temp lps #611

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

To/#610 extend temp lps #611

wants to merge 3 commits into from

Conversation

t-ober
Copy link
Contributor

@t-ober t-ober commented Jun 4, 2022

resolves #610

@t-ober
Copy link
Contributor Author

t-ober commented Jun 4, 2022

@sebastian-peter I'm not really satisfied with this implementation as the referenceTemperature and minTemperature should be static. But since you can not declare abstract static fields nor methods I don't find a way to declare them in the interface but make the subclasses set the specific value. I'm probably missing the right way to do it. Maybe you can help me out once more 👼🏼

@sonarqubegithubprchecks

This comment has been minimized.

1 similar comment
@sonarqubegithubprchecks
Copy link

Failed

  • 57.14% Coverage on New Code (is less than 72.00%)

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • 50 percent coverage57.14% Coverage (77.20% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.60% Estimated after merge)

Project ID: edu.ie3:PowerSystemDataModel

View in SonarQube

@sebastian-peter
Copy link
Member

@t-ober since the (power) values are fully handled by SIMONA and the within PSDM we (up until now) only provide keys and inputs, wouldn't it make sense to provide this info in SIMONA instead?

@t-ober
Copy link
Contributor Author

t-ober commented Jun 7, 2022

@t-ober since the (power) values are fully handled by SIMONA and the within PSDM we (up until now) only provide keys and inputs, wouldn't it make sense to provide this info in SIMONA instead?

@sebastian-peter I thought about this too but I that information is part of the actual input as the calculation gets parameterized by it and we need to make sure that this gets supplied for every subclass of temperature dependent profiles as the values differ between different profile of different grid providers. So if you would put them in SIMONA for adding a different profile set e.g. WestnetzTemperatureDependentLoadProfiles we would need to make a new datastructure in SIMONA setting up the additional parameters. All in all I think this should be part of the PSDM data model as it specifically is input for the calculation later on.

@t-ober t-ober marked this pull request as draft June 7, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend TemperatureDependantLoadProfiles with reference temperature and minimal temperature
2 participants