Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of time stamp pattern in factories #331

Draft
wants to merge 28 commits into
base: dev
Choose a base branch
from

Conversation

ckittl
Copy link
Member

@ckittl ckittl commented Apr 16, 2021

Closes #330. Take care of #329 beforehand.

@ckittl ckittl added the bug Something isn't working label Apr 16, 2021
@ckittl ckittl added this to the Version 2.0 milestone Apr 16, 2021
@ckittl ckittl requested a review from a team April 16, 2021 12:44
@ckittl ckittl self-assigned this Apr 16, 2021
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #331 (f25150e) into dev (e716924) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #331      +/-   ##
============================================
- Coverage     78.05%   77.95%   -0.10%     
- Complexity     2102     2105       +3     
============================================
  Files           257      257              
  Lines          8401     8401              
  Branches        815      814       -1     
============================================
- Hits           6557     6549       -8     
- Misses         1441     1449       +8     
  Partials        403      403              
Impacted Files Coverage Δ Complexity Δ
...ctory/timeseries/TimeBasedWeatherValueFactory.java 77.77% <0.00%> (-22.23%) 5.00% <0.00%> (+2.00%) ⬇️
...actory/timeseries/TimeBasedSimpleValueFactory.java 95.45% <0.00%> (-4.55%) 15.00% <0.00%> (-1.00%)
...models/timeseries/repetitive/LoadProfileInput.java 40.90% <0.00%> (-2.57%) 2.00% <0.00%> (-1.00%)
.../ie3/datamodel/io/connectors/CsvFileConnector.java 75.59% <0.00%> (-1.79%) 32.00% <0.00%> (-1.00%)
...el/io/source/couchbase/CouchbaseWeatherSource.java 72.09% <0.00%> (-1.08%) 14.00% <0.00%> (+1.00%) ⬇️
...odel/io/source/influxdb/InfluxDbWeatherSource.java 87.00% <0.00%> (-0.78%) 24.00% <0.00%> (+3.00%) ⬇️
...y/timeseries/IconTimeBasedWeatherValueFactory.java 94.59% <0.00%> (-0.15%) 9.00% <0.00%> (-1.00%)
...l/io/factory/timeseries/TimeBasedValueFactory.java 100.00% <0.00%> (ø) 4.00% <0.00%> (+3.00%)
...y/timeseries/PsdmTimeBasedWeatherValueFactory.java
.../timeseries/CosmoTimeBasedWeatherValueFactory.java 92.00% <0.00%> (ø) 5.00% <0.00%> (?%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7b1587...f25150e. Read the comment docs.

@ckittl ckittl force-pushed the ck/#330-factoryTimestampPattern branch from fc8fedd to f25150e Compare April 21, 2021 09:22
@sebastian-peter sebastian-peter modified the milestones: Version 4.1, Version 4.2 Nov 2, 2023
@sebastian-peter sebastian-peter modified the milestones: Version 4.2, Version 5.0 Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistency check for date time pattern if using InfluxDB
3 participants