-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of time stamp pattern in factories #331
Draft
ckittl
wants to merge
28
commits into
dev
Choose a base branch
from
ck/#330-factoryTimestampPattern
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asedWeatherValueFactory
Codecov Report
@@ Coverage Diff @@
## dev #331 +/- ##
============================================
- Coverage 78.05% 77.95% -0.10%
- Complexity 2102 2105 +3
============================================
Files 257 257
Lines 8401 8401
Branches 815 814 -1
============================================
- Hits 6557 6549 -8
- Misses 1441 1449 +8
Partials 403 403 Continue to review full report at Codecov.
|
…emeOfCOSMOWeatherData
…ng the implementation
ckittl
force-pushed
the
ck/#330-factoryTimestampPattern
branch
from
April 21, 2021 09:22
fc8fedd
to
f25150e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #330. Take care of #329 beforehand.