[ base ] Better set's toList
implementation + preparation for cleanup
#3425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is mainly the less controversial part of #3392, reimplementing and deprecating completely useless specialised
toList
function fromSortedSet
.Additionally, this PR contains some preparation to future removing the redundant
Libraries.Data.Sorted{Set|Map}
from the compiler's internal lib, the fact coming from times whenSorted{Set|Map}
were incontrib
. But currently, they cannot be replaced, because implementations in the compiler's lib have several functions that are missing in the implementation atbase
, so I suggest adding them there, while also doing the same thing with deprecating specialisedtoList
, so that we just could remove those redundant modules once we've released new version of the compiler.I made all changed in different commits in order to make review easier.
Should this change go in the CHANGELOG?
implementation, I have updated
CHANGELOG_NEXT.md
(and potentially alsoCONTRIBUTORS.md
).