WithFC elab #3423
Open
WithFC elab #3423
+132
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 25, 2024
|
Alrighty, as expected, lots of breakage with elaboration. I've gotten some PRs ready to fix the changes, can their author confirm the fix is ok? @stefan-hoeck for elab-utils, @alexhumphreys for idrall and maybe @mattpolzin for LSP-lib? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update reflected TTImp to replicate the change that were made in the compiler's tree.
This is also needed as part of a fix for #3417
Unfortunately, I suspect this is going to break a number of elaboration scripts. Hopefully this is something #3421 can help with in the future.
Should this change go in the CHANGELOG?
implementation, I have updated
CHANGELOG_NEXT.md(and potentially alsoCONTRIBUTORS.md).