Use external package for monotonic alignment search #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eginhard
force-pushed
the
mas
branch
3 times, most recently
from
8af98f0 to
5b62e29
Compare
Setuptools is not needed anymore because the Cython extension is now built in an external package.
demo-anon
approved these changes
Nov 8, 2024
KarlHajal
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The monotonic alignment search Cython code (originally from Glow-TTS) was the only reason Coqui needed separate builds for different operating systems and Python versions. I moved it into a separate PyPI package that provides these wheels and also makes it easier to use that code in other projects.
This simplifies the Coqui build a lot and means we can just build one universal wheel.