Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds ruby testing matrix, upgrades gems and code to support multiple versions of ruby #153

Merged
merged 7 commits into from
Nov 13, 2023
Merged

adds ruby testing matrix, upgrades gems and code to support multiple versions of ruby #153

merged 7 commits into from
Nov 13, 2023

Conversation

saikumar9
Copy link
Member

@saikumar9 saikumar9 commented Nov 7, 2023 •
edited
Loading

  • Added ruby matrix testing to verify if the code works properly for different versions of Ruby that are used across different applications in the Ideacrew enterprise.
  • Removed require 'pry' in spec_helper.
  • Updated code to use YAML.load instead of YAML.safe_load to support Ruby version 3.2.2.
  • Upgraded the gem timecop from 0.9 to 0.9.8 to support Ruby version 3.1.4

Note: This has code from #149

@saikumar9 saikumar9 changed the title Pivotal 186384674 adds ruby testing matrix, upgrades gems and code to support multiple versions of ruby Nov 7, 2023
@saikumar9 saikumar9 marked this pull request as draft November 7, 2023 21:01
@saikumar9 saikumar9 changed the base branch from feature_enabled_fixes to trunk November 8, 2023 18:19
@saikumar9 saikumar9 requested a review from TreyE November 13, 2023 18:18
@saikumar9 saikumar9 marked this pull request as ready for review November 13, 2023 18:19
@saikumar9 saikumar9 enabled auto-merge (squash) November 13, 2023 18:19
@saikumar9 saikumar9 requested a review from a team November 13, 2023 18:24
@saikumar9 saikumar9 merged commit 326b560 into trunk Nov 13, 2023
5 checks passed
@saikumar9 saikumar9 mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saipraveen18 saipraveen18 saipraveen18 approved these changes

@TreyE TreyE TreyE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saikumar9 @TreyE @saipraveen18