Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds ruby testing matrix, upgrades gems and code to support multiple versions of ruby #152

Closed
wants to merge 5 commits into from
Closed

adds ruby testing matrix, upgrades gems and code to support multiple versions of ruby #152

wants to merge 5 commits into from

Conversation

saikumar9
Copy link
Member

@saikumar9 saikumar9 commented Nov 7, 2023 •
edited
Loading

  • Added ruby matrix testing to verify if the code works properly for different versions of Ruby that are used across different applications in the Ideacrew enterprise.
  • Removed require 'pry' in spec_helper.
  • Updated code to use YAML.load instead of YAML.safe_load to support Ruby version 3.2.2.
  • Upgraded the gem timecop from 0.9 to 0.9.8 to support Ruby version 3.1.4

Note: This has code from both #150 and #149

@saikumar9 saikumar9 marked this pull request as draft November 7, 2023 20:08
@saikumar9 saikumar9 changed the base branch from trunk to feature_enabled_fixes November 7, 2023 20:08
@saikumar9 saikumar9 changed the base branch from feature_enabled_fixes to trunk November 7, 2023 20:08
@saikumar9 saikumar9 changed the base branch from trunk to feature_enabled_fixes November 7, 2023 20:48
@saikumar9 saikumar9 changed the title Test bug fix with gem updates adds ruby testing matrix, upgrades gems and code to support multiple versions of ruby Nov 7, 2023
@saikumar9 saikumar9 closed this Nov 7, 2023
@saikumar9 saikumar9 deleted the test_bug_fix_with_gem_updates branch November 7, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saikumar9 @TreyE