Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds postprocessor to track time step number for transient problems #29128

Open
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

anshchaube
Copy link

Minor quality-of-life improvement for users who want to track time step counts during their MOOSE simulations.

closes #29127

Minor quality-of-life improvement for users who want to track
time step counts during their MOOSE simulations.

closes idaholab#29127
Copy link
Contributor

@GiudGiud GiudGiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice this is almost ready

test/tests/postprocessors/num_time_steps/tests Outdated Show resolved Hide resolved
test/tests/postprocessors/num_time_steps/tests Outdated Show resolved Hide resolved
@GiudGiud GiudGiud self-assigned this Nov 24, 2024
@GiudGiud
Copy link
Contributor

let's squash all these commits togther in just a

address review
- updated wording
- added docstrings

commit message

test/tests/postprocessors/num_time_steps/moose.i Outdated Show resolved Hide resolved
@moosebuild
Copy link
Contributor

moosebuild commented Nov 24, 2024

Job Documentation, step Docs: sync website on ac0ce11 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Dec 1, 2024

Job Coverage, step Generate coverage on 20aa5b1 wanted to post the following:

Framework coverage

cedfd0 #29128 20aa5b
Total Total +/- New
Rate 85.14% 85.14% +0.00% 91.67%
Hits 107658 107669 +11 11
Misses 18792 18793 +1 1

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

- updated wording, file names based on suggestions
- added docstrings
- simplified test, changed dt
Apply suggestions from code review

corrects code listing path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a postprocessor that returns the time step number
5 participants