Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the Geometry-UOs to MoveNodes meshmodifier #29001

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

GiudGiud
Copy link
Contributor

@GiudGiud GiudGiud commented Nov 4, 2024

refs #9587 and #27671

do you prefer SnapNodes over MoveNodes ?

@GiudGiud GiudGiud self-assigned this Nov 4, 2024
@moosebuild
Copy link
Contributor

moosebuild commented Nov 5, 2024

Job Documentation, step Docs: sync website on c9a1db0 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Coverage, step Generate coverage on 8dbcaaf wanted to post the following:

Framework coverage

af6bed #29001 8dbcaa
Total Total +/- New
Rate 85.09% 85.09% -0.01% 83.93%
Hits 106734 106732 -2 47
Misses 18696 18704 +8 9

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

Warnings

  • framework new line coverage rate 83.93% is less than the suggested 90.0%

This comment will be updated on new commits.

@GiudGiud GiudGiud marked this pull request as ready for review November 19, 2024 00:20
Copy link
Member

@lindsayad lindsayad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dschwen this is your code so can you weigh-in on the name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants