-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update parameter descriptions to use new API #397
base: devel
Are you sure you want to change the base?
Changes from 4 commits
0bfce67
9a630e7
6ede39d
168b001
7fc5b8d
e9a1316
6c53cdf
eea17f3
194b8e1
48c1392
048f33f
8020fc4
0479c15
db7bb31
b5df938
aa528b4
4607275
75fe0cb
faf07cb
ec3ebbb
fdc35f0
175d5b9
3b392f4
4fdc4b1
500568d
a59aeb0
9075c74
679ae58
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,9 +39,12 @@ ConcreteASREigenstrain::validParams() | |
params.addRequiredRangeCheckedParam<Real>( | ||
"characteristic_time", | ||
"characteristic_time > 0.0", | ||
"Chracteristic ASR time (in days) at reference temprature. (tau_C(T_0))"); | ||
"Chracteristic ASR time at reference temprature. (tau_C(T_0))"); | ||
params.setDocUnit("characteristic_time", "d"); | ||
params.addRequiredParam<Real>("latency_time", | ||
"Latency ASR time (in days) at reference temprature (tau_L(T_0))"); | ||
"Latency ASR time at reference temprature (tau_L(T_0))"); | ||
params.setDocUnit("latency_time", "d"); | ||
// WGA - energy units? | ||
params.addRangeCheckedParam<Real>("characteristic_activation_energy", | ||
5400.0, | ||
"characteristic_activation_energy > 0.0", | ||
|
@@ -275,7 +278,7 @@ ConcreteASREigenstrain::computeResidual(unsigned qp, Real scalar) | |
// Convert current temperature to Kelvin | ||
const Real T = _temperature[qp] + _temp_offset; | ||
|
||
// ASR characteristic and latency times (in days) | ||
// ASR characteristic and latency times (in ) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Leave this one as it was. Same with the one below (Line 315) |
||
Real tau_c = _tau_c_T0 * std::exp(_Uc * (1.0 / T - 1.0 / _ref_temp)); | ||
Real tau_L = f * _tau_L_T0 * std::exp(_UL * (1.0 / T - 1.0 / _ref_temp)); | ||
|
||
|
@@ -309,7 +312,7 @@ ConcreteASREigenstrain::computeDerivative(unsigned qp, Real scalar) | |
// Convert current temperature to Kelvin | ||
const Real T = _temperature[qp] + _temp_offset; | ||
|
||
// ASR characteristic and latency times (in days) | ||
// ASR characteristic and latency times (in ) | ||
Real tau_c = _tau_c_T0 * std::exp(_Uc * (1.0 / T - 1.0 / _ref_temp)); | ||
Real tau_L = f * _tau_L_T0 * std::exp(_UL * (1.0 / T - 1.0 / _ref_temp)); | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,6 +24,7 @@ ConcreteExpansionEigenstrainBase::validParams() | |
"expansion_type", expansion_type, "Type of expansion resulting from volumetric strain"); | ||
params.addRangeCheckedParam<Real>( | ||
"compressive_strength", "compressive_strength > 0", "Compressive strength of concrete"); | ||
// WGA - unclear if units are needed? | ||
bwspenc marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Delete this comment now. |
||
params.addRangeCheckedParam<Real>( | ||
"expansion_stress_limit", | ||
"expansion_stress_limit > 0", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,15 +42,17 @@ ConcreteExpansionMicrocrackingDamage::validParams() | |
"Correction factor by which the eigenstrain is multiplied before " | ||
"evaluating the damage"); | ||
|
||
params.addRequiredRangeCheckedParam<Real>( | ||
"microcracking_initiation_strain", | ||
"microcracking_initiation_strain > 0", | ||
"Linear strain at which the microcracking initiates (in [m/m])"); | ||
// WGA - [m/m] ??? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Strain is unitless, so just don't even set it. |
||
params.addRequiredRangeCheckedParam<Real>("microcracking_initiation_strain", | ||
"microcracking_initiation_strain > 0", | ||
"Linear strain at which the microcracking initiates"); | ||
params.setDocUnit("microcracking_initiation_strain", "[m/m]"); | ||
|
||
params.addRequiredRangeCheckedParam<Real>( | ||
"microcracking_strain_branch", | ||
"microcracking_strain_branch > 0", | ||
"Parameter controlling the rate at which the microcracking increases (in [m/m])"); | ||
"Parameter controlling the rate at which the microcracking increases"); | ||
params.setDocUnit("microcracking_strain_branch", "[m/m]"); | ||
|
||
params.addParam<Real>( | ||
"expansion_stress_limit", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,11 +38,15 @@ ConcreteLogarithmicCreepModel::validParams() | |
1, | ||
"long_term_characteristic_time > 0", | ||
"Rate at which the long_term viscosity increases"); | ||
params.addCoupledVar("temperature", "Temperature variable [in Celsius]"); | ||
// WGA - using 0C for degrees celcius | ||
params.addCoupledVar("temperature", "Temperature variable"); | ||
params.setDocUnit("temperature", "0C"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we just use "C" for Celsius, but need to confirm. |
||
params.addRangeCheckedParam<Real>("activation_temperature", | ||
"activation_temperature >= 0", | ||
"Activation temperature for the creep [in Kelvin]"); | ||
params.addParam<Real>("reference_temperature", 20, "Reference temperature [in Celsius]"); | ||
"Activation temperature for the creep"); | ||
params.setDocUnit("activation_temperature", "K"); | ||
params.addParam<Real>("reference_temperature", 20, "Reference temperature"); | ||
params.setDocUnit("reference_temperature", "0C"); | ||
params.addCoupledVar("humidity", "Humidity variable"); | ||
params.addRangeCheckedParam<Real>("drying_creep_viscosity", | ||
bwspenc marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"drying_creep_viscosity > 0", | ||
|
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -71,25 +71,34 @@ ConcreteThermalMoisture::validParams() | |||||||
params.addParam<MooseEnum>( | ||||||||
"aggregate_pore_type", aggregate_pore_type, "aggregate pore structure"); | ||||||||
|
||||||||
params.addParam<Real>("cement_mass", "cement mass (kg) per m^3"); | ||||||||
params.addParam<Real>("aggregate_mass", "aggregate mass (kg) per m^3"); | ||||||||
// WGA - unclear if units for following two params is kg or kg/m^3 - assuming kg | ||||||||
bwspenc marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
params.addParam<Real>("cement_mass", "cement mass per m^3"); | ||||||||
params.setDocUnit("cement_mass", "kg"); | ||||||||
params.addParam<Real>("aggregate_mass", "aggregate mass per m^3"); | ||||||||
params.setDocUnit("aggregate_mass", "kg"); | ||||||||
params.addParam<Real>("water_to_cement_ratio", "water to cement ratio"); | ||||||||
params.addParam<Real>("aggregate_vol_fraction", "volumetric fraction of aggregates"); | ||||||||
params.addParam<Real>("concrete_cure_time", "concrete curing time in days"); | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change is still needed. |
||||||||
params.addParam<Real>("ref_density", "refernece density of porous media Kg/m^3"); | ||||||||
params.addParam<Real>("ref_specific_heat", "reference specific heat of concrete J/Kg/0C"); | ||||||||
params.addParam<Real>("ref_thermal_conductivity", | ||||||||
"concrete reference thermal conductivity (W/m/C)"); | ||||||||
params.addParam<Real>("ref_density", "refernece density of porous media"); | ||||||||
HiddenRoom marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
params.setDocUnit("ref_density", "kg/m^3"); | ||||||||
params.addParam<Real>("ref_specific_heat", "reference specific heat of concrete"); | ||||||||
params.setDocUnit("ref_specific_heat", "J/kg/0C"); | ||||||||
HiddenRoom marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
// WGA - Watts / Meters / ??? - what is C? | ||||||||
HiddenRoom marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
params.addParam<Real>("ref_thermal_conductivity", "concrete reference thermal conductivity"); | ||||||||
params.setDocUnit("ref_thermal_conductivity", "W/m/C"); | ||||||||
HiddenRoom marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
|
||||||||
// parameters for Bazant mositure transport model | ||||||||
params.addParam<Real>("D1", "empirical constants (m2/s)"); | ||||||||
// WGA - m2 = m^2 ?? - assuming so? | ||||||||
HiddenRoom marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
params.addParam<Real>("D1", "empirical constants"); | ||||||||
params.setDocUnit("D1", "m^2/s"); | ||||||||
params.addParam<Real>("n", "empirical constants"); | ||||||||
params.addParam<Real>("critical_relative_humidity", "empirical constants"); | ||||||||
params.addParam<Real>("coupled_moisture_diffusivity_factor", | ||||||||
"coupling coefficient mositure transfer due to heat"); | ||||||||
|
||||||||
// parameters for Mensi's moisture model | ||||||||
params.addParam<Real>("A", "empirical constants (m2/s)"); | ||||||||
params.addParam<Real>("A", "empirical constants"); | ||||||||
params.setDocUnit("A", "m^2/s"); | ||||||||
params.addParam<Real>("B", "empirical constants"); | ||||||||
|
||||||||
params.addCoupledVar("relative_humidity", "nonlinear variable name for rel. humidity"); | ||||||||
bwspenc marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,6 +39,7 @@ DamagePlasticityStressUpdate::validParams() | |
"ft_ep_slope_factor_at_zero_ep", | ||
"ft_ep_slope_factor_at_zero_ep <= 1 & ft_ep_slope_factor_at_zero_ep >= 0", | ||
"slope of ft vs plastic strain curve at zero plastic strain"); | ||
// WGA - unit needed for this? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Damage is unitless. Stress and strain have units, but I believe we're flexible on what system the user chooses. |
||
params.addRequiredParam<Real>( | ||
"tensile_damage_at_half_tensile_strength", | ||
"fraction of the elastic recovery slope in tension at 0.5*ft0 after yielding"); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The units for characteristic_activation_energy and latency_activation_energy are K. That's a little odd since they're temperature rather than energy units, so it's not really quite right to call them energies, but that's how the model is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also suggest adding these two in the appropriate locations. I'm not sure if the API will support this, but I want to capture that we need to deal with this: