-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add waist_imu in urdf file #99
Conversation
Thanks @martinaxgloria ! Could you add in the PR post a test in the simulator? |
310af91
to
72a2fda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes made on the urdf have been done by hand or it is the result of the generation from simmechanics_to_urdf
?
Checking the CI the generation of the urdf fails because XSENS_MTI_630_IMU_CSYS
does not exist in the simmechanics xml, since we decided to not update for now the simulation model with the creo 9->7 procedure.
The only idea I have is to refer to the torso_1 csys and use
additionalTransformation
-> https://github.com/robotology/icub-models-generator/blob/fd2d430a399119f2ded5a15f1c8ea4185b9aca6c/simmechanics/CMakeLists.txt#L279
for getting the correct orientation.
@traversaro is there a better way to add a frame that does not exist in the xml?
I did it by hand. |
In the past we just used |
I added the @traversaro is this what you were referring to? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now seems ok!
I squashed the commit in order to be easily reversible (see #106) |
As per title. WIP