Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A collection of "low-hanging fruit" refactors #612

Open
wants to merge 15 commits into
base: typecheck-spatial
Choose a base branch
from
Open

A collection of "low-hanging fruit" refactors #612

wants to merge 15 commits into from

Commits on Oct 23, 2024

  1. Remove unnecessary assignments

    @mfisher87
    mfisher87 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ad0426b View commit details
    Browse the repository at this point in the history

  2. Simplify return conditionals

    @mfisher87
    mfisher87 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ca64fa3 View commit details
    Browse the repository at this point in the history

  3. Avoid assigning to builtin

    @mfisher87
    mfisher87 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    68519d0 View commit details
    Browse the repository at this point in the history

  4. Annotate and lightly refactor is2ref

    @mfisher87
    mfisher87 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    f538b01 View commit details
    Browse the repository at this point in the history

  5. Remove assignment to builtin

    @mfisher87
    mfisher87 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e51ce31 View commit details
    Browse the repository at this point in the history

  6. Fix method to raise as intended

    @mfisher87
    mfisher87 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    a57bd12 View commit details
    Browse the repository at this point in the history

  7. More types for query module

    @mfisher87
    mfisher87 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    534f2c5 View commit details
    Browse the repository at this point in the history

  8. Add some missing annotations

    @mfisher87
    mfisher87 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    82f5b85 View commit details
    Browse the repository at this point in the history

  9. Extract CMR provider string to constant

    @mfisher87
    mfisher87 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    a89d069 View commit details
    Browse the repository at this point in the history

  10. Refactor Query.granules property to cached_property

    @mfisher87
    mfisher87 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    2e7ac19 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Merge branch 'typecheck-spatial' into low-hanging-refactors

    @trey-stafford
    trey-stafford committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e6151d1 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Fixup docstring

    @trey-stafford
    trey-stafford committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    4dc2872 View commit details
    Browse the repository at this point in the history

  2. Fixup docstring line

    @trey-stafford
    trey-stafford committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a180892 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Update pyproject.toml to remove pyright ignore 

    Co-authored-by: Jessica Scheick <[email protected]>
    @trey-stafford @JessicaS11
    trey-stafford and JessicaS11 authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    88459e5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'typecheck-spatial' into low-hanging-refactors

    @trey-stafford
    trey-stafford committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    77112b7 View commit details
    Browse the repository at this point in the history