Port fix for rust-windowing/winit/issues/2291 #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md
if knowledge of this change could be valuable to usersChange affects Windows platform only.
This is a prospective fix ported from the original issue. Observed this to fix the problem of launching a dialog (e.g.
rfd::FileDialog
) sometimes crashing aniced
application. With fix in place, crash no longer occurs. Because the dialog essentially runs a new pump and blocks the main thread, the application will not receive other messages (such as those sent from background threads). These messages are observed to get queued up and then delivered once the dialog is closed and the main thread pump resumes. I do not know if this is the desired behavior or if a more main-event-loop friendly way of handling these kinds of dialogs is something that can be done.