Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port fix for rust-windowing/winit/issues/2291 #14

Open
wants to merge 2 commits into
base: v0.28.6
Choose a base branch
from

Conversation

ChronosWS
Copy link

@ChronosWS ChronosWS commented Nov 12, 2023

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

Change affects Windows platform only.

This is a prospective fix ported from the original issue. Observed this to fix the problem of launching a dialog (e.g. rfd::FileDialog) sometimes crashing an iced application. With fix in place, crash no longer occurs. Because the dialog essentially runs a new pump and blocks the main thread, the application will not receive other messages (such as those sent from background threads). These messages are observed to get queued up and then delivered once the dialog is closed and the main thread pump resumes. I do not know if this is the desired behavior or if a more main-event-loop friendly way of handling these kinds of dialogs is something that can be done.

@ChronosWS ChronosWS marked this pull request as ready for review November 12, 2023 02:05
@dtzxporter
Copy link

This is no longer an issue on winit 0.29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants