Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend existing moment instance before loading from dependencies #118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Extend existing moment instance before loading from dependencies #118

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e48b41
Extend existing moment instance before loading from dependencies
Mihailoff Jun 28, 2020
62d05dc
Fix coffescript syntaxis
Mihailoff Jul 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/twix.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ makeTwix = (moment) ->
Twix

# -- MAKE AVAILABLE
return module.exports = makeTwix(require 'moment') if hasModule
return module.exports = makeTwix(if moment then return moment else require 'moment') if hasModule
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't this throw if moment hasn't been defined as a global?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In plain JS will work, in CoffeeScript honestly, I don't know. Just double-checked, this code passes tests return module.exports = makeTwix(if moment? then moment else require 'moment') if hasModule

Also, it may have adverse effects on existing users, so technically this should be part of a major "potentially breaking" release.


if typeof(define) == 'function' && define.amd
define 'twix', ['moment'], (moment) -> makeTwix(moment)
Expand Down