-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Infinite Geocoders, Support Offline Geocoder #28
Changes from 10 commits
6de6390
8564364
b54c97f
c75fbab
477b3dc
07f98a9
0a5518c
1542319
6d74c69
b816cc0
1794cf4
8bff9d9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,17 +1,5 @@ | ||||||
LAMBDA_EXEC_SG: Insert AWS Security Group ID Here (it must be in the same VPC as the subnet) | ||||||
LAMBDA_EXEC_SUBNET: Insert AWS Subnet ID Here (it must be in the same VPC as the security group) | ||||||
BUGSNAG_NOTIFIER_KEY: INSERT BUGSNAG NOTIFIER KEY HERE | ||||||
GEOCODER_API_KEY: INSERT API KEY HERE | ||||||
GEOCODE_EARTH_URL: https://api.geocode.earth/v1 # Not needed if geocode.earth is not used | ||||||
CSV_ENABLED: true | ||||||
CUSTOM_PELIAS_URL: http://<insert your Pelias endpoint here>/v1 | ||||||
GEOCODER: HERE # Options: HERE, PELIAS | ||||||
TRANSIT_GEOCODER: (optional) OTP/PELIAS | ||||||
TRANSIT_BASE_URL: (conditionally required) OTP instance when TRANSIT_GEOCODER=OTP (/otp/routers/{routerId}) | ||||||
|
||||||
SECONDARY_GEOCODER: (optional) HERE/PELIAS | ||||||
SECONDARY_GEOCODER_API_KEY: (optional) INSERT SECONDARY API KEY HERE | ||||||
SECONDARY_GEOCODE_EARTH_URL: (optional) https://api.geocode.earth/v1 # Not needed if geocode.earth is not used | ||||||
|
||||||
REDIS_HOST: (optional) <insert IP of redis host here> | ||||||
REDIS_KEY: (optional) <insert redis password here> | ||||||
GEOCODERS: <JSON Array of OTP-UI `GeocoderConfig`s> | ||||||
BACKUP_GEOCODERS: <JSON Array of OTP-UI `GeocoderConfig`s. Same length as GEOCODERS> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are backup geocoders supposed to be in the same order as the main ones? Is each backup geocoder at a given index supposed to be of the same kind as the main one? If so, would it make sense to write something like:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That would make sense but we're dealing with serverless which loads all these in as env variables. Doing what you suggest is technically possible but would be a huge overhead to implement There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same thing, just tweak the comment:
Suggested change
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can this be a JSON array?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's stringified!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. Can you just tweak: