refactor: address pr feedback

ibi-group · Mar 25, 2024 · 1794cf4 · 1794cf4
1 parent b816cc0
commit 1794cf4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/env.example.yml b/env.example.yml
@@ -1,5 +1,5 @@
 LAMBDA_EXEC_SG: Insert AWS Security Group ID Here (it must be in the same VPC as the subnet)
 LAMBDA_EXEC_SUBNET: Insert AWS Subnet ID Here (it must be in the same VPC as the security group)
 BUGSNAG_NOTIFIER_KEY: INSERT BUGSNAG NOTIFIER KEY HERE
-GEOCODERS: <JSON Array of OTP-UI `GeocoderConfig`s>
-BACKUP_GEOCODERS: <JSON Array of OTP-UI `GeocoderConfig`s. Same length as GEOCODERS> 
+GEOCODERS: <Stringified JSON Array of OTP-UI `GeocoderConfig`s>
+BACKUP_GEOCODERS: <Stringified JSON Array of OTP-UI `GeocoderConfig`'s. Same length and order as GEOCODERS> 
diff --git a/handler.ts b/handler.ts
@@ -102,6 +102,7 @@ export const makeGeocoderRequests = async (
   responses = await Promise.all(
     responses.map(async (response, index) => {
       // If backup geocoder is present, and the returned results are garbage, use the backup geocoder
+      // if one is configured. This request will not be cached
       if (
         backupGeocoders[index] &&
         !checkIfResultsAreSatisfactory(