-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trip survey forward URL #280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish our version of MongoDB would work with the java.time.*
classes rather than java.util.Date
, but apparently that can't be helped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor nits. Apart from them, all good.
@@ -129,6 +130,7 @@ private static void initializeHttpEndpoints() throws IOException { | |||
new LogController(API_PREFIX), | |||
new ErrorEventsController(API_PREFIX), | |||
new CDPFilesController(API_PREFIX), | |||
new TripSurveyController(API_PREFIX), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit. Shame these aren't ordered alphabetically.
@Override | ||
public void bind(final SparkSwagger restApi) { | ||
restApi.endpoint( | ||
endpointPath(ROOT_ROUTE).withDescription("Interface for tracking opened trip surveys following a trip survey notification"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit. Full stop.
Checklist
dev
before they can be merged tomaster
)Description
This PR adds an endpoint that forwards to the post-travel survey. The endpoint is intended for use after tapping a corresponding push notification and will log the opened date of the push notification.