Propagate delete companion #278
Conversation
|
|
||
| // If a dependent user, remove self as the primary traveler in trips created by other users. | ||
| // TODO: Should we alert the user who created the trip of the deletion? | ||
| Persistence.monitoredTrips |
There was a problem hiding this comment.
There is probably a case here for just deleting the trip if the primary traveler is no longer travelling. Perhaps that would start to complicate things though?!
There was a problem hiding this comment.
Good observation. Could preventing tracking if a companion is set but no primary traveler is defined be a better way to handle that?
There was a problem hiding this comment.
I think deleting the trip makes sense if there is no primary traveler.
There was a problem hiding this comment.
Created issue #282 to track that.
|
|
||
| /** | ||
| * Remove the specified user as observer from the specified trip. | ||
| * @return true if one or more related users gor invalidated, false otherwise. |
There was a problem hiding this comment.
Thanks! 528d8bb
| .getFiltered(Filters.eq("companion.email", email)) | ||
| .forEach(trip -> removeCompanion(this, trip)); | ||
|
|
||
| // If a companion user, invalidate relationship in trips where they are companions and observers. |
There was a problem hiding this comment.
nit. this comment is a duplicate of the comment above.
|
|
||
| // If a dependent user, remove self as the primary traveler in trips created by other users. | ||
| // TODO: Should we alert the user who created the trip of the deletion? | ||
| Persistence.monitoredTrips |
There was a problem hiding this comment.
I think deleting the trip makes sense if there is no primary traveler.
| .forEach(trip -> removeCompanion(this, trip)); | ||
|
|
||
| // If a companion user, invalidate relationship in trips where they are companions and observers. | ||
| // TODO: Should we alert the user who created the trip of the deletion? |
There was a problem hiding this comment.
I don't think it would hurt to notify the creator of the trip.
Checklist
devbefore they can be merged tomaster)Description
This PR addresses #271 (comment).
When a user deletes their account, they are removed as primary traveler on trips saved by others,
and they are invalidated as companions and observers on trips saved by others.