-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Stop Time Interpolation #998
Conversation
Note that in 62216ca I did some i18n but there remains a TODO to figure out how to apply |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems simple enough although there are some strings you haven't localized. Is that intentional?
return function (dispatch: dispatchFn, getState: getStateFn) { | ||
const {data} = getState().editor | ||
const {feedSourceId} = data.active | ||
const sessionId = data.lock.sessionId || '' | ||
const url = `/api/editor/secure/pattern/${patternId}/stop_times?feedId=${feedSourceId || ''}&sessionId=${sessionId}&stopSequence=${beginStopSequence}` | ||
const url = `/api/editor/secure/pattern/${patternId}/stop_times?feedId=${feedSourceId || ''}&sessionId=${sessionId}&stopSequence=${beginStopSequence}&interpolateStopTimes=${interpolateStopTimes.toString()}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a crazy hack but glad it works
Yeah that's intentional, there are |
Checklist
dev
before they can be merged tomaster
)Description
Front end PR to add support for stop time interpolation in the NormalizeStopTimes modal.
Backend PR: ibi-group/datatools-server#572
GTFS-lib PR: conveyal/gtfs-lib#399