Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not require stop_code to be unique #993

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Do not require stop_code to be unique #993

merged 2 commits into from
Oct 16, 2023

Conversation

philip-cline
Copy link
Contributor

@philip-cline philip-cline commented Oct 12, 2023 •
edited by binh-dam-ibigroup
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

Fix #987 . Stop_code should not be required to be unique. This PR also slightly amends the help text associated with stop_code.

binh-dam-ibigroup
binh-dam-ibigroup reviewed Oct 13, 2023
View reviewed changes
gtfs.yml Outdated Show resolved Hide resolved
binh-dam-ibigroup
binh-dam-ibigroup approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small question about the documentation.

miles-grant-ibigroup
miles-grant-ibigroup approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can we add a validation item that says it's nice if they are?

@philip-cline
Copy link
Contributor Author

I will ticket adding "nice to have" validation, since that's not currently configurable.

@philip-cline philip-cline merged commit e504f28 into dev Oct 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@philip-cline philip-cline

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop code uniqueness should not be mandatory
3 participants
@philip-cline @binh-dam-ibigroup @miles-grant-ibigroup