Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Mobility Data Validator to 4.2.0 #1006

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Upgrade Mobility Data Validator to 4.2.0 #1006

merged 1 commit into from
Jan 4, 2024

Conversation

miles-grant-ibigroup
Copy link
Contributor

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

4.2.0 brings new validators! And a few changes which we account for here

daniel-heppner-ibigroup
daniel-heppner-ibigroup approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update thanks

philip-cline
philip-cline approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@philip-cline philip-cline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

.gitignore Show resolved Hide resolved
lib/manager/components/validation/MobilityDataValidationResult.js Show resolved Hide resolved
@miles-grant-ibigroup miles-grant-ibigroup merged commit 98807cf into dev Jan 4, 2024
5 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the fix-mobility-data-validation-again branch January 4, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-heppner-ibigroup daniel-heppner-ibigroup daniel-heppner-ibigroup approved these changes

@philip-cline philip-cline philip-cline approved these changes

Assignees

@miles-grant-ibigroup miles-grant-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miles-grant-ibigroup @philip-cline @daniel-heppner-ibigroup @AdrianaCeric