Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream merge 2024-07-11 #218

Merged
merged 66 commits into from
Jul 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
01df869
return systemUrl, filter neareast by network, hide unwanted networks …
sharhio Jun 14, 2024
d8b5fc7
schema
sharhio Jun 14, 2024
7f69e90
docs
sharhio Jun 14, 2024
d88617c
Use vehicleRentalSystemType to return system url
sharhio Jun 17, 2024
814846e
replace name with default if empty
sharhio Jun 17, 2024
778d0de
filterByNetwork naming
sharhio Jun 17, 2024
fa4627f
removed network hiding option in maplayers
sharhio Jun 17, 2024
5ef5fb5
filterByNetwork description
sharhio Jun 17, 2024
e6603e1
Fixed vehiclerentalsystem
sharhio Jun 18, 2024
aa8d4ae
no network filtering in transmodel
sharhio Jun 18, 2024
8a77828
Update src/main/java/org/opentripplanner/updater/vehicle_rental/datas…
sharhio Jun 19, 2024
f70c31d
import fixed
sharhio Jun 19, 2024
8523e34
mapper class, fix name check
sharhio Jun 19, 2024
f00e907
Document integration with OSM
leonardehrenfried Jun 25, 2024
e942193
Skip more mappers
leonardehrenfried Jun 26, 2024
c28736b
Move Portland specific tags to PortlandMapper
leonardehrenfried Jun 26, 2024
669da72
Finetune look of tables
leonardehrenfried Jun 26, 2024
69f9076
Remove bike safety endpoint from Report API
leonardehrenfried Jun 26, 2024
75af424
Update Javadoc
leonardehrenfried Jun 26, 2024
d0ec77e
Improve handling of SIRI added trip with unresolvable agency
vpaturet Jun 27, 2024
1850dd1
Use immutable collections in timetable snapshot.
vpaturet Jun 27, 2024
22d2123
Apply review feedback
leonardehrenfried Jul 2, 2024
22ed45e
Prevent modifications on read-only timetables
vpaturet Jun 27, 2024
93a132a
Apply review feedback
leonardehrenfried Jul 2, 2024
b057fbc
Update src/main/java/org/opentripplanner/openstreetmap/wayproperty/sp…
leonardehrenfried Jul 3, 2024
a9441a7
Improve Javadoc
leonardehrenfried Jul 3, 2024
2a07977
Allow configuration of allowKeepingAtDestination
leonardehrenfried Jul 3, 2024
39cfada
Add changelog entry
leonardehrenfried Jul 3, 2024
3c81fca
Remove unused code
optionsome Jul 3, 2024
41df32c
Merge remote-tracking branch 'upstream/dev-2.x' into rentalvehicle-de…
optionsome Jul 4, 2024
b64b08a
Add and update GraphQL integration tests
optionsome Jul 4, 2024
9a3edc1
Add place finder tests for rental
optionsome Jul 4, 2024
babd0fa
Disable Legacy REST API by default
leonardehrenfried Jul 5, 2024
66dedbb
Fix copy-on-write in TimetableSnapshot
vpaturet Jul 1, 2024
7ab29bc
Call system network in schema and move network id there
optionsome Jul 5, 2024
3eaa5d0
Add system to smoove stations
optionsome Jul 5, 2024
b9a0c82
Add more required fields to smoove system
optionsome Jul 5, 2024
7f7bbee
fix(deps): update jackson.version to v2.17.2
renovate[bot] Jul 5, 2024
de9640b
Use immutable set when purging expired data
vpaturet Jul 7, 2024
c8f9bba
Update src/ext/java/org/opentripplanner/ext/vehiclerentalservicedirec…
leonardehrenfried Jul 8, 2024
87bda74
Improve documentation and make list items non null
optionsome Jul 8, 2024
d1d8235
Flesh out documentation a bit more
leonardehrenfried Jul 8, 2024
9a2b8de
Remove unused method
leonardehrenfried Jul 8, 2024
d083bfd
Update docs
leonardehrenfried Jul 8, 2024
b6d4aeb
Use hyphenated anchors
leonardehrenfried Jul 8, 2024
e508838
Merge pull request #5909 from HSLdevcom/rentalvehicle-details
optionsome Jul 8, 2024
b064330
Add changelog entry for #5909 [ci skip]
Jul 8, 2024
0579e22
Update micrometer.version to v1.13.2
renovate[bot] Jul 9, 2024
ca06ad2
Merge pull request #5949 from opentripplanner/renovate/jackson.version
leonardehrenfried Jul 9, 2024
893409e
Merge pull request #5952 from opentripplanner/renovate/micrometer.ver…
leonardehrenfried Jul 9, 2024
0a34d24
Increase container image pruning to 365 days [ci skip]
leonardehrenfried Jul 9, 2024
0237509
Merge pull request #5931 from entur/fix_siri_journey_unresolvable_agency
vpaturet Jul 9, 2024
203db5d
Add changelog entry for #5931 [ci skip]
Jul 9, 2024
20fc8ce
Merge pull request #5944 from leonardehrenfried/allow-keeping
leonardehrenfried Jul 9, 2024
05b9f38
Merge pull request #5934 from entur/use_immutable_collections_in_time…
vpaturet Jul 10, 2024
d283fdf
Inline isDirty variable
vpaturet Jul 10, 2024
9f3fc97
Merge branch 'refs/heads/dev-2.x' into fix_copy_on_write_when_reverti…
vpaturet Jul 10, 2024
07bdb99
Fix typo
leonardehrenfried Jul 10, 2024
6dfc0be
chore(deps): update dependency org.apache.maven.plugins:maven-surefir…
renovate[bot] Jul 10, 2024
e51f4c5
Merge pull request #5941 from entur/fix_copy_on_write_when_reverting_…
vpaturet Jul 11, 2024
31af103
Add changelog entry for #5941 [ci skip]
Jul 11, 2024
8404481
Merge pull request #5929 from leonardehrenfried/document-osm
leonardehrenfried Jul 11, 2024
962d128
Add changelog entry for #5929 [ci skip]
Jul 11, 2024
8de9f88
Merge pull request #5948 from leonardehrenfried/disable-rest-api
leonardehrenfried Jul 11, 2024
2a397c7
Add changelog entry for #5948 [ci skip]
Jul 11, 2024
08e5484
Merge remote-tracking branch 'upstream/dev-2.x' into upstream-merge-2…
leonardehrenfried Jul 11, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/prune-container-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ jobs:
# remove all snapshot container images that have not been pulled for over a year
# --keep-semver makes sure that any image with a x.y.z version scheme is unaffected by this
pip install prune-container-repo==0.0.4
prune-container-repo -u ${CONTAINER_REGISTRY_USER} -r ${CONTAINER_REPO} --days=90 --keep-semver --activate
prune-container-repo -u ${CONTAINER_REGISTRY_USER} -r ${CONTAINER_REPO} --days=365 --keep-semver --activate
30 changes: 30 additions & 0 deletions doc-templates/OsmMapper.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# OSM tag mapping

This page is intended to give an overview of which OpenStreetMap(OSM) tags OTP uses to evaluate its
walking and bicycling instructions. If a tag is not part of the documentation on this page
then this tag mapper (profile) does not use it.

The exception are access permissions and wheelchair accessibility tags like

- `access=no`
- `wheelchair=no`
- `oneway=yes`

These are identical for all mappers and not separately listed on this page.

### Way properties

Way properties set a way's permission and optionally influences its walk and bicycle safety factors.

These factors determine how desirable an OSM way is when routing for cyclists and pedestrians.
Lower safety values make an OSM way more desirable and higher values less desirable.

<!-- INSERT: props -->

### Safety mixins

Mixins are selectors that have only an effect on the bicycle and walk safety factors but not on the
permission of an OSM way. Their safety values are multiplied with the base values from the selected
way properties. Multiple mixins can apply to the same way and their effects compound.

<!-- INSERT: mixins -->
13 changes: 7 additions & 6 deletions doc-templates/sandbox/VehicleRentalServiceDirectory.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# Vehicle Rental Service Directory API support.
# Vehicle Rental Service Directory API support

This adds support for the GBFS service directory endpoint component located at
https://github.com/entur/lamassu. OTP uses the service directory to lookup and connect to all GBFS
endpoints registered in the directory. This simplifies the management of the GBFS endpoints, since
multiple services/components like OTP can connect to the directory and get the necessary
configuration from it.
This adds support for the GBFS service directory endpoint component
[Lamassu](https://github.com/entur/lamassu).
OTP uses the service directory to lookup and connects to all GBFS endpoints registered in the
directory. This simplifies the management of the GBFS endpoints, since multiple services/components
like OTP can connect to the directory and get the necessary configuration from it.


## Contact Info
Expand All @@ -17,6 +17,7 @@ configuration from it.
- Initial implementation of bike share updater API support
- Make json tag names configurable [#3447](https://github.com/opentripplanner/OpenTripPlanner/pull/3447)
- Enable GBFS geofencing with VehicleRentalServiceDirectory [#5324](https://github.com/opentripplanner/OpenTripPlanner/pull/5324)
- Enable `allowKeepingVehicleAtDestination` [#5944](https://github.com/opentripplanner/OpenTripPlanner/pull/5944)


## Configuration
Expand Down
5 changes: 5 additions & 0 deletions docs/Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ based on merged pull requests. Search GitHub issues and pull requests for smalle
- Fix NullPointerException in stop transfer priority cost vector generation [#5943](https://github.com/opentripplanner/OpenTripPlanner/pull/5943)
- Convert transferSlack configuration to duration [#5897](https://github.com/opentripplanner/OpenTripPlanner/pull/5897)
- Expose stop transfer priority in Transmodel API [#5942](https://github.com/opentripplanner/OpenTripPlanner/pull/5942)
- Add rental system to GraphQL API [#5909](https://github.com/opentripplanner/OpenTripPlanner/pull/5909)
- Improve handling of SIRI added trip with unresolvable agency [#5931](https://github.com/opentripplanner/OpenTripPlanner/pull/5931)
- Fix copy-on-write in TimetableSnapshot [#5941](https://github.com/opentripplanner/OpenTripPlanner/pull/5941)
- Generate documentation for OSM tag mappers [#5929](https://github.com/opentripplanner/OpenTripPlanner/pull/5929)
- Disable Legacy REST API by default [#5948](https://github.com/opentripplanner/OpenTripPlanner/pull/5948)
[](AUTOMATIC_CHANGELOG_PLACEHOLDER_DO_NOT_REMOVE)

## 2.5.0 (2024-03-13)
Expand Down
2 changes: 1 addition & 1 deletion docs/Configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ Here is a list of all features which can be toggled on/off and their default val
| `FaresV2` | Enable import of GTFS-Fares v2 data. | | ✓️ |
| `FlexRouting` | Enable FLEX routing. | | ✓️ |
| `GoogleCloudStorage` | Enable Google Cloud Storage integration. | | ✓️ |
| `LegacyRestApi` | Enable legacy REST API. This API will be removed in the future. | ✓️ | ✓️ |
| `LegacyRestApi` | Enable legacy REST API. This API will be removed in the future. | | ✓️ |
| `RealtimeResolver` | When routing with ignoreRealtimeUpdates=true, add an extra step which populates results with real-time data | | ✓️ |
| `ReportApi` | Enable the report API. | | ✓️ |
| `RestAPIPassInDefaultConfigAsJson` | Enable a default RouteRequest to be passed in as JSON on the REST API - FOR DEBUGGING ONLY! | | |
Expand Down
Loading
Loading