DO NOT MERGE: Expose full details about geocoding clusters (primary/secondaries) #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also capitalize constant identifier
add updater reads from buffer add garbage collection
Uniformly add RT_AB to all TODO and FIXME comments
Co-authored-by: Leonard Ehrenfried <[email protected]>
Co-authored-by: Thomas Gran <[email protected]>
Co-authored-by: Thomas Gran <[email protected]>
Co-authored-by: Thomas Gran <[email protected]>
Document and validate timeRange GraphQL parameter
…/debug-ui-dependencies-(non-major)
…en-plugin to v1.6.14
With this it's possible to differentiate between entries added because of configuration and those from runtime requests, the latter being candidates for the former.
…/jersey-monorepo fix(deps): update jersey monorepo to v3.1.7
…ter/transit/request/RaptorRequestTransferCache.java Co-authored-by: Henrik Abrahamsson <[email protected]>
…ayer-no-stoptimes Realtime stops vectortile layer checks whether there are stoptimes on the service day
…er-cache-request-origin Log the origin of a request that causes a transfer cache addition.
…en-plugin to v1.7.0
leonardehrenfried
force-pushed
the
cluster-geocoder
branch
2 times, most recently
from
d4858c0 to
d46d895
Compare
…departure_time_handling Fix handling of missing aimed departure time
leonardehrenfried
force-pushed
the
cluster-geocoder
branch
from
f9f5f49 to
78cd79b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the tech call and Jira, this is a backwards-incompatible change for indexing and exposing the full details of a geocoding stop cluster.
You can now search by any of the cluster's elements' name or code and the full cluster with primary and secondary elements is returned.
An example of the new JSON response is here: https://gist.github.com/leonardehrenfried/7c7140407098b64417c7ffe7506c4139
Note that this doesn't include any special handling of shared stops. Hence they will only become a cluster when they have an identical name and are closer than 100m meter to one another. Also, the primary location is chosen at random.