Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shared stops to Seattle smoke tests #203

Merged
merged 5 commits into from
Feb 15, 2024

Conversation

leonardehrenfried
Copy link

@leonardehrenfried leonardehrenfried commented Feb 15, 2024

Since this is a feature that will easily break, I'm adding a specific smoke test for it.

Lets see how often this creates false positives and decide if it's worth the bother.

@leonardehrenfried leonardehrenfried force-pushed the stop-consolidation-smoke-test branch from d0387ec to a7bebee Compare February 15, 2024 16:37
@leonardehrenfried leonardehrenfried changed the title Flesh out Seattle smoke test Add shared stops to Seattle smoke tests Feb 15, 2024
@leonardehrenfried leonardehrenfried marked this pull request as ready for review February 15, 2024 20:22
{
"type" : "gtfs",
"feedId" : "commtrans",
"source" : "https://picsapi.commtrans.org/download/liveGTFS.zip"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've always wondered about this host name. What is "picsapi"? A pictures API?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked this once I think it's something crazy like passenger information collation system

Copy link

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Excited to give it a try

@miles-grant-ibigroup miles-grant-ibigroup merged commit cd11987 into ibi-dev-2.x Feb 15, 2024
16 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the stop-consolidation-smoke-test branch February 15, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants