Upstream merge 2023-10-20 #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The McRequest failed to copy all parameters in the constructor, which caused the factory methods to not work as expected.
…ortKey for sorting purposes. This simplifies reading and writing start and end times from serialized page cursors. The timezone is not needed for sorting.
…timization/services/TestTransferBuilder.java Co-authored-by: Leonard Ehrenfried <[email protected]>
Co-authored-by: Leonard Ehrenfried <[email protected]>
…l_start_time_parameter Fix handling of null start time in Transmodel API
…ough-optimize-transfers-service Pass through optimize transfers service
Add ItinerarySortKey interface
…ness Improve geocoding fuzziness, remove street corners
…/major-geotools.version fix(deps): update geotools.version to v30 (major)
…stops Allow multiple zones in an unscheduled flex trip
|
There is a critical bug in upstream so let's wait until I've clarified how bad it is. |
|
The bug only appears in a pretty rare edge case (two stops times using the same minute but different number of seconds) and its consequences are benign: the transfer optimization selects the wrong one of these stops. It's only because another change (not yet merged) surfaced that it even existed. |
|
Draft/BLocked until this <1 minute bug is fixed |
miles-grant-ibigroup
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release brings in the geocoder improvements from opentripplanner#5401. It also removes the indexing of street corners in the geocoder so start up time is improved.
Another nice new feature is the support for realtime vehicle occupancy from GTFS-RT feeds.
Edit
The PR that fixes the CCSWW feed was also merge a few minutes ago: opentripplanner#5376