Improved codebase quality

ibexa · Nov 19, 2024 · b863460 · b863460
1 parent 292423c
commit b863460
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/bundle/DependencyInjection/Compiler/KernelOverridePass.php b/src/bundle/DependencyInjection/Compiler/KernelOverridePass.php
@@ -45,7 +45,7 @@ public function process(ContainerBuilder $container): void
      *
      * @param \Symfony\Component\DependencyInjection\ContainerBuilder $container
      */
-    private function setStandardThemeDirectories(ContainerBuilder $container)
+    private function setStandardThemeDirectories(ContainerBuilder $container): void
     {
         if (!$container->hasParameter('kernel.bundles_metadata')) {
             return;
@@ -57,6 +57,7 @@ private function setStandardThemeDirectories(ContainerBuilder $container)
             return;
         }
 
+        /** @var array<string, string[]>  $templatesPathMap */
         $templatesPathMap = $container->hasParameter('ibexa.design.templates.path_map')
             ? $container->getParameter('ibexa.design.templates.path_map')
             : [];

diff --git a/src/bundle/DependencyInjection/Compiler/StandardThemePass.php b/src/bundle/DependencyInjection/Compiler/StandardThemePass.php
@@ -28,9 +28,10 @@ public function process(ContainerBuilder $container): void
             return;
         }
 
+        /** @var array<string, string[]> $designList */
         $designList = $container->getParameter('ibexa.design.list');
         foreach ($designList as $designName => $themes) {
-            if (!in_array('standard', $themes)) {
+            if (!in_array('standard', $themes, true)) {
                 $designList[$designName][] = 'standard';
             }
         }

diff --git a/src/bundle/DependencyInjection/IbexaStandardDesignExtension.php b/src/bundle/DependencyInjection/IbexaStandardDesignExtension.php
@@ -16,9 +16,9 @@
 
 class IbexaStandardDesignExtension extends Extension implements PrependExtensionInterface
 {
-    public const EXTENSION_NAME = 'ibexa_standard_design';
+    public const string EXTENSION_NAME = 'ibexa_standard_design';
 
-    public const OVERRIDE_KERNEL_TEMPLATES_PARAM_NAME = 'ibexa.design.standard.override_kernel_templates';
+    public const string OVERRIDE_KERNEL_TEMPLATES_PARAM_NAME = 'ibexa.design.standard.override_kernel_templates';
 
     public function getAlias(): string
     {