Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8536: Removed deprecations in graphql #71

Merged
merged 4 commits into from
Oct 23, 2024
Merged

IBX-8536: Removed deprecations in graphql #71

merged 4 commits into from
Oct 23, 2024

Conversation

glye
Copy link
Contributor

@glye glye commented Jul 22, 2024 •
edited by ViniTou
Loading

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@glye glye marked this pull request as ready for review July 24, 2024 15:14
@glye glye requested review from tischsoic, konradoboza and a team July 24, 2024 15:15
konradoboza
konradoboza approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay-ish as long as regressions or E2E GraphQL tests don't expose any missing usage.

@konradoboza konradoboza requested a review from a team August 21, 2024 13:00
@glye
Copy link
Contributor Author

glye commented Aug 22, 2024

@konradoboza Am looking into getting all tests running. Is there an up to date doc on installing v5? Am struggling with https://ibexa.atlassian.net/wiki/spaces/ENG/pages/5701714/Installation+via+Flex and dev-master / 5.0.x-dev.

@ViniTou ViniTou mentioned this pull request Oct 21, 2024
Merged
@ViniTou ViniTou force-pushed the ibx8536-resolve-deprecations branch from 685bfdc to f4bd44b Compare October 21, 2024 14:06
@ViniTou ViniTou force-pushed the ibx8536-resolve-deprecations branch from f4bd44b to 72ad3f8 Compare October 21, 2024 14:19
@ViniTou ViniTou self-requested a review October 21, 2024 14:19
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@konradoboza konradoboza requested a review from a team October 23, 2024 06:27
@ViniTou ViniTou mentioned this pull request Oct 23, 2024
Closed
@konradoboza
Copy link
Contributor

Merging as regressions passed, ref: https://github.com/ibexa/commerce/actions/runs/11477344169/job/31939210332?pr=1088.

@konradoboza konradoboza merged commit e58bfd7 into main Oct 23, 2024
9 checks passed
@konradoboza konradoboza deleted the ibx8536-resolve-deprecations branch October 23, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbialcz tbialcz tbialcz approved these changes

@konradoboza konradoboza konradoboza approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

@ViniTou ViniTou Awaiting requested review from ViniTou

Assignees

@tischsoic tischsoic

@konradoboza konradoboza

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@glye @konradoboza @ViniTou @tbialcz @tischsoic