Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerated PHPStan #453

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Regenerated PHPStan #453

merged 1 commit into from
Nov 19, 2024

Conversation

Steveb-p
Copy link
Contributor

🎫 Issue N/A

Description:

Seems like external changes removed two of the PHPStan errors.

For QA:

Documentation:

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@adamwojs
Copy link
Member

Unit tests will be fixed in a follow up PR by @Steveb-p

@adamwojs adamwojs merged commit 9fda0ec into 4.6 Nov 19, 2024
15 of 17 checks passed
@adamwojs adamwojs deleted the phpstan branch November 19, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@tischsoic tischsoic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Steveb-p @adamwojs @mikadamczyk @konradoboza @alongosz @tischsoic