Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Growth rate #4

Merged
merged 5 commits into from
Mar 22, 2020
Merged

Growth rate #4

merged 5 commits into from
Mar 22, 2020

Conversation

ashawe
Copy link
Contributor

@ashawe ashawe commented Mar 22, 2020

A partial solution to #3

@ashawe
Merge branch 'master' of https://github.com/iamrohitsuthar/gocoronago
ba128ca
@ashawe
✨ Add growth Rate function
6c3e3ba
@ashawe
✨ Add chart
e32c84e 
* ✨ Add Chart for previous data

include chartjs
make another api call

* 💄 Make Chart Responsive

Make the footer responsive

* ✨ Add Chart for previous data

include chartjs
make another api call
add contributor name
@ashawe
Merge branch 'master' of https://github.com/ashawe/gocoronago into gr…
d783a33 
…owth-rate
@iamrohitsuthar iamrohitsuthar changed the base branch from master to new_feature March 22, 2020 13:07
@iamrohitsuthar
Copy link
Owner

  1. Instead of writing separate function for Growth Rate please add the Growth Rate computation in the getDataForChart() function.
  2. and also pull the latest changes from the "new_feature" branch and make pull request to "new_feature" branch.

@ashawe
Copy link
Contributor Author

ashawe commented Mar 22, 2020 •
edited
Loading

I don't think there is any need to pull your changes into my branch since I've only made changes to parts of main.js which have not been touched by your branch or to be specific, we didn't change the same parts of the file ( But still I did it ).

I believe keeping getDataForChart() and getGrowthRate() two different functions is a good programming practice, as both of them are two different tasks.

Do you still want me to put them inside one function?

@ashawe ashawe force-pushed the growth-rate branch 2 times, most recently from ec1f33a to 8825563 Compare March 22, 2020 13:53
@iamrohitsuthar
Copy link
Owner

Ok.
No, leave them separte!

@iamrohitsuthar iamrohitsuthar merged commit 37d8cd8 into iamrohitsuthar:new_feature Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashawe @iamrohitsuthar