Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tqdm module #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add tqdm module #15

wants to merge 3 commits into from

Conversation

mirusu400
Copy link

Honeycam 2021-10-22 10-22-16

Now we can easily check the download progress instead of looks like lagging.

@iamleot
Copy link
Owner

iamleot commented Oct 25, 2021

Thanks @mirusu400 for working on that, I think that's useful and would address an entry in the TODO (I originally thought about making it visible via possible signals but I think that's nicer!)! :)

Do you think if tqdm module can be made optional?

Also, if that's not the case, can it be disabled via, let's say -s option like curl?

What do you think?

Thanks again!

transferwee.py Outdated Show resolved Hide resolved
transferwee.py Outdated Show resolved Hide resolved
transferwee.py Outdated Show resolved Hide resolved
transferwee.py Outdated Show resolved Hide resolved
@ytuploader
Copy link

ytuploader commented Jan 21, 2022

can we have a merge with this?
this would be a great update !
and please add the process bar also to the upload feature =)

@mirusu400
Copy link
Author

Sorry for the late review, I changed some parts and add -s arguments about tqdm progress.

@iamleot iamleot self-requested a review April 13, 2022 15:10
Copy link

@barakplasma barakplasma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, makes tqdm optional and allows the user to see progress\

closes #13 and #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants