Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CONTRIBUTING.md #277

Merged
merged 1 commit into from
Nov 13, 2023
Merged

update CONTRIBUTING.md #277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@ If `esmock` is failing for you, feel free to submit a PR that reproduces the iss

Please do not submit PRs to convert esmock to typescript or add build scripts. Typescript and build scripts are fine, however, esmock's current setup is ideal for me now.

When it comes to adding examples to README, please follow the constraints below:
- The example should work. It should be possible to write a real unit-test that passes with the example,
- Each line less than 70 characters wide. This is a special optimization for the README so the examples fit inside most laptop screens without scrollbars,
- The example should be slightly interesting, if possible, and should use a unicode emoji
Collaborators may reject or revert any issue or PR for any reason.


[0]: https://github.com/iambumblehead/esmock/tree/master/tests
[0]: https://github.com/iambumblehead/esmock/tree/main/tests