Bug fix for api.extendOptions()

iVis-at-Bilkent · Aug 7, 2019 · 7f9a67b · 7f9a67b
1 parent 7b6ae3e
commit 7f9a67b
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 14 deletions.
diff --git a/cytoscape-expand-collapse.js b/cytoscape-expand-collapse.js
diff --git a/src/index.js b/src/index.js
@@ -54,18 +54,22 @@
       };
 
       api.extendOptions = function(opts) {
-        handleNewOptions(opts);
         var options = getScratch(cy, 'options');
-        extendOptions( options, opts );
+        let newOptions = extendOptions( options, opts );
+        handleNewOptions(newOptions);
+        setScratch(cy, 'options', newOptions);
       }
 
       // set the option whose name is given
       api.setOption = function (name, value) {
-        var nameToVal = {};
-        nameToVal[ name ] = value;
+        var opts = {};
+        opts[ name ] = value;
+
+        var options = getScratch(cy, 'options');
+        let newOptions = extendOptions( options, opts );
 
-        handleNewOptions(nameToVal);
-        getScratch(cy, 'options')[name] = value;
+        handleNewOptions(newOptions);
+        setScratch(cy, 'options', newOptions);
       };
 
       // Collection functions