-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement TwitchSpawn with Architectury API #69
Open
BONNe
wants to merge
15
commits into
iGoodie:master
Choose a base branch
from
BONNePlayground:architectury
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All these changes were made to allow TwitchSpawn to run on 1.20.2. - Update gradle version - add settings.gradle as it is new standard for projects - add sound event registry and augment type registry - rework item parsing, as it is changed - rework network manager and usage to apply 1.20 changes - switch from performCommand to performPrefixedCommand - fix some gui rendering to reflect 1.20 changes - Replace TranslatableComponent to the new Component#translatable
This screen is triggered on client startup and has config errors (like in forge). Remove unnecessary parts from the optimizing screen exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Architectury API
This allows easy Fabric/Forge transformations and compile mods for both environments with minimal changes required.
This pull request contains all changes required to run TwitchSpawn on fabric and forge servers. The plugin's main logic is moved to the common project which is built on Architectury API.
The fabric and forge projects now contain just mod loader-specific changes, such as mixins, events and starters.
As Fabric does not have an error screen like a forge, this pull request contains the error screen for the mod config errors, which is opened when a player starts any client. The screen contains Open Config, Reload Config and Continue buttons.
There were some changes required to the localization, as Minecraft parses with %s unlike forge with {}.
Also, I fixed the sub-title that displayed the mob name, as it was not parsed, and added the Latvian locale, because I could.