chore: update test deps #1782

ripecosta · 2024-08-12T21:46:52Z

### Description

Update all test related dependencies possible at this stage. See comments for more info.

Checklist

only relevant code is changed (make a diff before you submit the PR)
run tests npm run test
tests are included
commit message and code follows the Developer's Certification of Origin

coveralls · 2024-08-12T21:48:30Z

coverage: 97.094% (-0.08%) from 97.17%
when pulling 56395fb on ripecosta:rc/update-tests
into 8a1ebc8 on i18next:master.

ripecosta · 2024-08-12T21:48:13Z

package.json

-    "@types/react": "^18.2.52",
-    "@vitest/coverage-v8": "^1.2.2",
+    "@testing-library/jest-dom": "^6.4.8",
+    "@testing-library/react": "^12.1.5",


@testing-library/react v13 drop support for react v17 and below so can't upgrade further unless this project also projects support for react v16.

ripecosta · 2024-08-12T21:49:21Z

package.json

-    "babel-plugin-macros": "^2.8.0",
-    "babel-plugin-tester": "^6.5.0",
+    "babel-plugin-macros": "^3.1.0",
+    "babel-plugin-tester": "^7.0.4",


Updating babel-plugin-preset produces a lot of snapshot changes because of how it formats them so it's best done in a separate PR.

ripecosta · 2024-08-12T21:49:56Z

package.json

+    "@testing-library/jest-dom": "^6.4.8",
+    "@testing-library/react": "^12.1.5",
+    "@testing-library/react-hooks": "^8.0.1",
+    "@types/jest": "^29.5.12",


@testing-library/jest-dom v6 no longer has @types/jest as its dependency so we need to import it explicitly now.

ripecosta · 2024-08-12T21:50:50Z

test/setup.js

-import { expect } from 'vitest';
-
-expect.extend(matchers);
+import '@testing-library/jest-dom/vitest';


See https://github.com/testing-library/jest-dom?tab=readme-ov-file#with-vitest

ripecosta · 2024-08-12T21:51:14Z

test/typescript/misc/Trans.test.tsx

@@ -126,7 +126,6 @@ describe('<Trans />', () => {
  it('should not work with object child', () => {
    assertType<React.ReactElement>(
      <Trans>
-        {/* @ts-expect-error */}


No longer necessary after downgrading @types/react to v16.

This assertion is necessary since the test checks that an error is thrown when there are object inside child computations and allowObjectInHTMLChildren is disabled.

Check the line below:

<span>This {{ var: '' }} is an error since `allowObjectInHTMLChildren` is disabled</span>

Probably that wasn't an issue with old react types.
This is another reason to update react version rather than downgrading @types/react

Reverted the @types/react downgrade since we decided to upgrade react instead.

ripecosta · 2024-08-12T21:53:03Z

package.json

+    "@testing-library/react": "^12.1.5",
+    "@testing-library/react-hooks": "^8.0.1",
+    "@types/jest": "^29.5.12",
+    "@types/react": "^16.14.60",


Downgrade @types/react to v16 was necessary because of @testing-library/react-hooks v8. Regardless, it makes sense to use v16 instead of v18 because that's this repo is using react v16 to test.

ripecosta · 2024-08-12T21:55:34Z

package.json

@@ -116,7 +117,7 @@
    "rimraf": "^6.0.1",
    "rollup": "^4.20.0",
    "typescript": "~5.5.4",
-    "vitest": "1.2.2",
+    "vitest": "^2.0.5",


vitest v2 (changelog) enables coverage.ignoreEmptyLines by default so coverage is expected to drop slightly in some files

marcalexiei

IMHO I think it would be better if react and @types/react have a more recent version, I would go with v18.
This means that we can use more recent version of other test dependencies, as stated in @ripecosta's comments.

What do you think @adrai?

adrai · 2024-08-13T06:19:47Z

IMHO I think it would be better if react and @types/react have a more recent version, I would go with v18.

This means that we can use more recent version of other test dependencies, as stated in @ripecosta's comments.

What do you think @adrai?

Yes, we can update to v18

ripecosta · 2024-08-13T09:22:30Z

Sounds good @adrai @marcalexiei. In that case for this PR I'll keep @testing-library/react-hooks at v7 so we can upgrade react in it's own PR. I will require releasing a new major version too so it's another reason to keep it separate.

socket-security · 2024-08-13T09:29:54Z

Report too large to display inline

View full report↗︎

socket-security · 2024-08-13T09:29:57Z

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source	CI
Install scripts	npm/[email protected]	Install script: install Source: `node install.js`	`example/razzle-ssr/package.json`	🚫

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@SocketSecurity ignore npm/[email protected]

chore: update test deps

6307472

adrai requested a review from marcalexiei August 12, 2024 21:47

ripecosta commented Aug 12, 2024

View reviewed changes

marcalexiei reviewed Aug 13, 2024

View reviewed changes

chore: revert @testing-library/react-hooks back to v7

56395fb

ripecosta requested a review from marcalexiei August 13, 2024 09:27

adrai merged commit 35b4821 into i18next:master Aug 13, 2024
8 of 9 checks passed

ripecosta deleted the rc/update-tests branch August 13, 2024 10:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update test deps #1782

chore: update test deps #1782

ripecosta commented Aug 12, 2024

coveralls commented Aug 12, 2024 •

edited

Loading

ripecosta Aug 12, 2024

ripecosta Aug 12, 2024

ripecosta Aug 12, 2024

ripecosta Aug 12, 2024

ripecosta Aug 12, 2024

marcalexiei Aug 13, 2024

ripecosta Aug 13, 2024

ripecosta Aug 12, 2024 •

edited

Loading

ripecosta Aug 12, 2024

marcalexiei left a comment

adrai commented Aug 13, 2024

ripecosta commented Aug 13, 2024 •

edited

Loading

socket-security bot commented Aug 13, 2024

socket-security bot commented Aug 13, 2024

chore: update test deps #1782

chore: update test deps #1782

Conversation

ripecosta commented Aug 12, 2024

Checklist

coveralls commented Aug 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ripecosta Aug 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcalexiei left a comment

Choose a reason for hiding this comment

adrai commented Aug 13, 2024

ripecosta commented Aug 13, 2024 • edited Loading

socket-security bot commented Aug 13, 2024

socket-security bot commented Aug 13, 2024

Next steps

coveralls commented Aug 12, 2024 •

edited

Loading

ripecosta Aug 12, 2024 •

edited

Loading

ripecosta commented Aug 13, 2024 •

edited

Loading