Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use modern hasLoadedNamespace code #1770

Conversation

VIKTORVAV99
Copy link
Contributor

@VIKTORVAV99 VIKTORVAV99 commented Jul 16, 2024

Uses the newer modern hasLoadedNamespace code.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@VIKTORVAV99
Copy link
Contributor Author

It seems like the internal i18n.hasLoadedNamespace is not always defined. Which is an error in other parts of the code.

I'll see if I can fix it but if anyone has any suggestions what the issue might be that would be appreciated.

return oldI18nextHasLoadedNamespace(ns, i18n, options);
}

// IN I18NEXT > v19.4.5 WE CAN (INTRODUCED JUNE 2020)
return i18n.hasLoadedNamespace(ns, {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the function that is sometimes undefined.

@adrai
Copy link
Member

adrai commented Jul 17, 2024

solved here: 648c705

@adrai adrai closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants