Fix tag converting behavior to match with react-i18next

i18next · Oct 24, 2022 · a8880f7 · a8880f7
1 parent 7e604e7
commit a8880f7
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/src/lexers/jsx-lexer.js b/src/lexers/jsx-lexer.js
@@ -165,10 +165,12 @@ export default class JsxLexer extends JavascriptLexer {
               const useTagName =
                 child.isBasic &&
                 this.transSupportBasicHtmlNodes &&
-                this.transKeepBasicHtmlNodesFor.includes(child.name)
+                this.transKeepBasicHtmlNodesFor.includes(child.name) &&
+                child.children.length <= 1 &&
+                child.children.every((v) => v.type === 'text')
               const elementName = useTagName ? child.name : index
               const childrenString = elemsToString(child.children)
-              return childrenString || !(useTagName && child.selfClosing)
+              return childrenString || !useTagName
                 ? `<${elementName}>${childrenString}</${elementName}>`
                 : `<${elementName}/>`
             default:
@@ -202,7 +204,6 @@ export default class JsxLexer extends JavascriptLexer {
             children: this.parseChildren(child.children, sourceText),
             name,
             isBasic,
-            selfClosing: child.kind === ts.SyntaxKind.JsxSelfClosingElement,
           }
         } else if (child.kind === ts.SyntaxKind.JsxExpression) {
           // strip empty expressions

diff --git a/test/lexers/jsx-lexer.test.js b/test/lexers/jsx-lexer.test.js
@@ -370,12 +370,19 @@ describe('JsxLexer', () => {
         done()
       })
 
-      it('keeps empty tag untouched when transSupportBasicHtmlNodes is true', (done) => {
+      it('converts empty tags to self-closing tags when transSupportBasicHtmlNodes is true', (done) => {
         const Lexer = new JsxLexer({ transSupportBasicHtmlNodes: true })
         const content = '<Trans>a<strong></strong>b</Trans>'
+        assert.equal(Lexer.extract(content)[0].defaultValue, 'a<strong/>b')
+        done()
+      })
+
+      it('ignores tagName when children is not a text when transSupportBasicHtmlNodes is true', (done) => {
+        const Lexer = new JsxLexer({ transSupportBasicHtmlNodes: true })
+        const content = '<Trans><p>ab</p><p>c<br />d</p><p>{"e"}f</p></Trans>'
         assert.equal(
           Lexer.extract(content)[0].defaultValue,
-          'a<strong></strong>b'
+          '<p>ab</p><1>c<br/>d</1><2>ef</2>'
         )
         done()
       })