Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ci.yml after any push to main #737

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Run ci.yml after any push to main #737

merged 1 commit into from
Sep 19, 2023

Conversation

seanh
Copy link
Contributor

@seanh seanh commented Sep 19, 2023

Re-run ci.yml on main after merging a PR (or after pushing commits
directly to main). This is necessary for two reasons:

  1. It updates GitHub Actions caches on main (which can be read from
    any PR branches), which saves time re-installing dependencies on PRs
  2. It will send us a Slack notification if CI fails on main

This will enable us to remove the ci.yml call from deploy.yml.

Re-run `ci.yml` on `main` after merging a PR (or after pushing commits
directly to `main`). This is necessary for two reasons:

1. It updates GitHub Actions caches on `main` (which can be read from
   any PR branches), which saves time re-installing dependencies on PRs
2. It will send us a Slack notification if CI fails on `main`

This will enable us to remove the `ci.yml` call from `deploy.yml`.
@seanh seanh merged commit 0ad6f0f into main Sep 19, 2023
4 checks passed
@seanh seanh deleted the run-ci-on-push branch September 19, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant