Toad fix burst only (old revived: needs careful review!) #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix some annoying log spam and rekey quicker.
Should fix bogus logging on nodes with darknet peers.
This fixes logger errors due to trying to reconnect to old opennet peers which are not in the routing table and not in the status table either, but get set to BURSTING on non-NATed nodes.
Mainly for squashing log errors, but the peer counts *are* used for important things, notably determining whether we need more opennet peers.
Conflicts: src/freenet/node/PeerNode.java
This reverts commit f98ac58. This is wrong. There is a better way... Conflicts: src/freenet/node/PeerNode.java
This makes much more sense. It also fixes the "old opennet peers in the peer status tracker" problem more cleanly, and removes some unnecessary argument cruft. (Renames forceCancelDisconnecting to onAdded and always calls it in PeerManager.addPeer)
Fixes a minor regression in recent fixes.
(Fixes more log spam)
…t-only fixed merge errors
ArneBab
force-pushed
the
toad-fix-burst-only
branch
from
2ccd6d3 to
12a46b8
Compare
Closed
ArneBab
changed the title
ArneBab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a copy of #396 with the merge errors fixed.
This needs careful review, though, because it merges changes from 2016 into the 2024 codebase. I did not review it yet.