Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted cleanup of DSA CryptoKey related classes #986

Open
wants to merge 10 commits into
base: next
Choose a base branch
from

Conversation

bertm
Copy link
Contributor

@bertm bertm commented Oct 5, 2024

A grab bag of code cleanup in CryptoKey, its subclasses and their related uses.

Most substantial change and reason for starting this exercise was the dubious (testing?) code in CryptoKey itself, that would allow instantiation of gadget classes if it was actually used (but it is not).
Next there is a lot of copying going on for immutable classes. This is now removed, and actual defensive copying for byte array is added.

This assumes that the wildest methods in these classes are not actually used anywhere outside of Fred.

Note: If we are somewhat confident that these methods are not used in plugins either, then I would also love to remove the SimpleFieldSet related methods.

@bertm bertm force-pushed the cleanup-cryptokey branch from cb127a0 to 643e8be Compare October 6, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant