Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 22.04 #1656

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Ubuntu 22.04 #1656

merged 4 commits into from
Apr 24, 2024

Conversation

KimEbert42
Copy link
Contributor

Ubuntu 22.04 upgrade

@WadeBarnes WadeBarnes changed the base branch from main to ubuntu-22.04 April 12, 2024 17:34
fix: remove setuptools as it conflicts with existing OS packages
chore: update github workflows
fix: fix tests
chore: use temp server
fix: fix deb package versioning
fix: fix msgpack dependency
fix: fix build
fix: add cython3
fix: fix checkpoint service
fix: fix popitem
fix: remove extra parameter from test_stats_publisher
fix: replace iloc with keys
fix: fix collections.Mapping to collections.abc.Mapping
fix: some collections still use last=False...
fix: fix append to add
fix: fix rlp
fix: fix lint
fix: fix popitem that uses last notation
fix: fix Iterable
chore: clean up un-needed files
chore: change to hyperledger github
fix: restore needed file that was cleaned up

Signed-off-by: Kim Ebert <[email protected]>
@KimEbert42 KimEbert42 marked this pull request as ready for review April 23, 2024 20:56
@KimEbert42 KimEbert42 requested a review from a team as a code owner April 23, 2024 20:56

# Automatically added from template:
if which py3compile >/dev/null 2>&1; then
py3compile -O -p {package_name} /usr/local/lib/python3.8/dist-packages/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python version will need to be updated accordingly for 22.04.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I missed this.

@WadeBarnes
Copy link
Member

WadeBarnes commented Apr 24, 2024

@reflectivedevelopment, I don't have permissions to update your branch. Would it be possible to setup the PR to allow maintainers to update your PR? I was trying to update the workflows and was going to look at updating the dev container.

To start could you enable the workflows on the ubuntu-22.04 branch please.

  • Update PR.yaml, and Push.yaml to include ubuntu-22.04 in the branch list.

# echo "deb https://repo.sovrin.org/sdk/deb bionic master" >> /etc/apt/sources.list

# TODO change this to official repo
RUN echo "deb [trusted=yes] http://209.141.41.82:8000/ packagedir/" >> /etc/apt/sources.list
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reflectivedevelopment, Which repo is this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temporary repo, until we get the jfrog packages installed.

Signed-off-by: Wade Barnes <[email protected]>
@WadeBarnes
Copy link
Member

Workflows and branch protection rules have been setup for the ubuntu-22.04 branch. Build is passing.

Found a small issue with the 3rd Party Dependency build that I want to fix before merging the PR so we get all the expected packages published once we merge.

@WadeBarnes WadeBarnes self-assigned this Apr 24, 2024
Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging knowing we've got some additional clean to do.

@WadeBarnes WadeBarnes merged commit 40e415a into hyperledger:ubuntu-22.04 Apr 24, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants