-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates CL contracts to use event based approach + Drop did:indy2 #11
Merged
Artemkaaas
merged 5 commits into
hyperledger:main
from
DSRCorporation:feature/cl-on-events
Jan 30, 2024
Merged
Updates CL contracts to use event based approach + Drop did:indy2 #11
Artemkaaas
merged 5 commits into
hyperledger:main
from
DSRCorporation:feature/cl-on-events
Jan 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: artem.ivanov <[email protected]>
Artemkaaas
force-pushed
the
feature/cl-on-events
branch
from
January 30, 2024 10:19
86c7b06
to
54c9400
Compare
Signed-off-by: artem.ivanov <[email protected]>
Artemkaaas
force-pushed
the
feature/cl-on-events
branch
from
January 30, 2024 10:26
54c9400
to
ef330f6
Compare
Signed-off-by: artem.ivanov <[email protected]>
Toktar
reviewed
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you a lot for this big design change!
No requests for change really, just a few questions.
And it will be nice if we can extend tests a bit according to new changes. Not urgent because updated demos cover most cases.
Artemkaaas
force-pushed
the
feature/cl-on-events
branch
from
January 30, 2024 14:10
7ea8326
to
bee9ce7
Compare
Toktar
approved these changes
Jan 30, 2024
Signed-off-by: artem.ivanov <[email protected]>
Artemkaaas
force-pushed
the
feature/cl-on-events
branch
from
January 30, 2024 14:25
bee9ce7
to
4952bd3
Compare
Toktar
approved these changes
Jan 30, 2024
Signed-off-by: artem.ivanov <[email protected]>
Artemkaaas
force-pushed
the
feature/cl-on-events
branch
from
January 30, 2024 14:59
4f02408
to
9bb3ad1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR contains the following changes:
did:indy2
method in favour of usingdid:ethr