feat: tutorial issue credential cloud agent issuer to edge agent holder #54
Conversation
goncalo-frade-iohk
requested review from
BS-IO,
elribonazo,
antonbaliasnikov,
petevielhaber and
lohanspies
There was a problem hiding this comment.
Great work @elribonazo - added some of my thoughts/recommendations.
documentation/docs/quick-start.md
Outdated
| ### Agent Deployment | ||
| In order to spin up a Prism Agent locally on your machine you must have docker installed as a requirement and its just required to clone the Prism Agent (building blocks) [repository](https://github.com/input-output-hk/atala-prism-building-blocks) and simply run the following command | ||
|
|
||
| For this guide we are going to be using a single tenant deployment with API Key authentication disabled. But detailed and more advanced configuration can be found in [Multi-Tenancy Management](/docs/atala-prism/prism-cloud-agent/multi-tenancy-management), [Authentication](/docs/atala-prism/prism-cloud-agent/authentication) and environment variables config [Environment Variables](/docs/atala-prism/prism-cloud-agent/environment-variables) |
There was a problem hiding this comment.
Do we want to make a comment about DIDs being on an in-memory ledger in this case? And perhaps something about their persistence?
There was a problem hiding this comment.
Check out what I added plz :)
documentation/docs/quick-start.md
Outdated
| 1. API ENDPOINT | ||
| 2. The [ConnectionId](/docs/quick-start#establish-a-connection-between-holder-and-prismagents) we created in previous step. | ||
| 3. The Published [prism DID](/docs/quick-start#3-agent-configuration-steps-pre-requisities) we created in previous step. | ||
| 4. The [schemaId](/docs/quick-start#3-agent-configuration-steps-pre-requisities) we created in previous step. |
There was a problem hiding this comment.
Suggest to replace with the above (and keep the links)
elribonazo
force-pushed
the
feature/ATL-5630
branch
2 times, most recently
from
10dddc9
to
7b209ae
Compare
|
Can we please change the |
Fixed this already and committed the changes. I see we also use |
Fixed
Fixed! |
documentation/docs/quick-start.md
Outdated
| Copy the `invitationUrl` and the `connectionId`. | ||
|
|
||
| ### Establish a connection - Holder side | ||
|
|
There was a problem hiding this comment.
| Now that you have the invitation, it's time for the Holder to accept it. |
|
@elribonazo the build is failing, I think because some of the links are not resolving |
static/img/component-diagram.png
Outdated
There was a problem hiding this comment.
I would reconsider the arrows in this diagram.
From my understanding:
- Wallet SDK talks directly to the Agent.
- The Agent talks to the Wallet SDK through the Mediator.
- And the Controller, as per my understanding, is also a part of the Wallet SDK (you can call REST API from the SDK and subscribe to the events)
- Minor styling tweaks
- Fixed glossary links
elribonazo
force-pushed
the
feature/ATL-5630
branch
from
5f8c5d9
to
cccb6ea
Compare
## [1.57.0](v1.56.0...v1.57.0) (2023-10-02) ### 🚀 New Content * tutorial issue credential cloud agent issuer to edge agent holder ([#54](#54)) ([66fae41](66fae41))
I think we need to gather opinions and create a template for this tutorials so we can provide the best content.
In this PR you can see that I organised the tutorial in Sections with Steps if needed, I did this because there is a lot of information and I felt just having steps is not enough.
Section 1
Section 2
Section 3