feat: ZKP verification #792

CryptoKnightIOG · 2023-11-18T17:03:58Z

Overview

Fixes https://input-output.atlassian.net/browse/ATL-5944

Checklist

My PR contains...

No code changes (changes to documentation, CI, metadata, etc.)
Bug fixes (non-breaking change which fixes an issue)
Improvements (misc. changes to existing features)
Features (non-breaking change which adds functionality)

My changes...

are breaking changes
are not breaking changes
If yes to above: I have updated the documentation accordingly

Documentation

My changes do not require a change to the project documentation
My changes require a change to the project documentation
If yes to above: I have updated the documentation accordingly

Tests

My changes can not or do not need to be tested
My changes can and should be tested by unit and/or integration tests
If yes to above: I have added tests to cover my changes
If yes to above: I have taken care to cover edge cases in my tests

github-actions · 2023-11-18T17:13:07Z

Integration Test Results

12 files ±0 12 suites ±0 2s ⏱️ ±0s
25 tests ±0 25 ✅ ±0 0 💤 ±0 0 ❌ ±0
26 runs ±0 26 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 94b0277. ± Comparison against base commit 1c6d894.

♻️ This comment has been updated with latest results.

github-actions · 2023-11-18T17:17:25Z

Atala PRISM Test Results

  87 files +  2   87 suites +2 21m 28s ⏱️ -5s
722 tests +10 714 ✔️ +10 8 💤 ±0 0 ❌ ±0
728 runs +10 720 ✔️ +10 8 💤 ±0 0 ❌ ±0

Results for commit 7e18b6a. ± Comparison against base commit 9a6e512.

This pull request removes 12 and adds 22 tests. Note that renamed tests count towards both.

io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - acceptPresentation updates the PresentatinRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - acceptProposePresentation updates the PresentatinRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - acceptRequestPresentation updates the PresentatinRecord JWT
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - createPresentationRecord creates a valid PresentationRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - markPresentationRejected updates the PresentatinRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - receivePresentation updates the PresentatinRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - receiveProposePresentation updates the PresentatinRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - receiveRequestPresentation updates the RequestPresentation in PresentatinRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - rejectPresentation updates the PresentatinRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - rejectRequestPresentation updates the PresentatinRecord
…

io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - acceptPresentation updates the PresentationRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - acceptProposePresentation updates the PresentationRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - acceptRequestPresentation should fail given unmatching format
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - acceptRequestPresentation updates the PresentationRecord AnonCreds
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - acceptRequestPresentation updates the PresentationRecord JWT
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - createPresentationRecord creates a valid Anoncred PresentationRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - createPresentationRecord creates a valid JWT PresentationRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - markPresentationRejected updates the PresentationRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - receivePresentation updates the PresentationRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - receiveProposePresentation updates the PresentationRecord
…

github-actions · 2023-11-20T14:20:34Z

Unit Test Results

88 files + 2 88 suites +2 19m 28s ⏱️ -23s
746 tests +12 738 ✅ +12 8 💤 ±0 0 ❌ ±0
753 runs +14 745 ✅ +14 8 💤 ±0 0 ❌ ±0

Results for commit 94b0277. ± Comparison against base commit 1c6d894.

This pull request removes 13 and adds 25 tests. Note that renamed tests count towards both.

io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - acceptPresentation updates the PresentatinRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - acceptProposePresentation updates the PresentatinRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - acceptRequestPresentation updates the PresentatinRecord JWT
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - createPresentationPayloadFromRecord returns jwt prsentation payload
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - createPresentationRecord creates a valid PresentationRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - markPresentationRejected updates the PresentatinRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - receivePresentation updates the PresentatinRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - receiveProposePresentation updates the PresentatinRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - receiveRequestPresentation updates the RequestPresentation in PresentatinRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - rejectPresentation updates the PresentatinRecord
…

io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - acceptPresentation updates the PresentationRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - acceptProposePresentation updates the PresentationRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - acceptRequestPresentation should fail given unmatching format
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - acceptRequestPresentation updates the PresentationRecord AnonCreds
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - acceptRequestPresentation updates the PresentationRecord JWT
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - createAnoncredPresentationPayloadFromRecord returns Anoncred presentation payload
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - createJwtPresentationPayloadFromRecord returns jwt presentation payload
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - createPresentationRecord creates a valid Anoncred PresentationRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - createPresentationRecord creates a valid JWT PresentationRecord
io.iohk.atala.pollux.core.service.PresentationServiceSpec ‑ PresentationService - singleWalletSpec - markPresentationRejected updates the PresentationRecord
…

♻️ This comment has been updated with latest results.

pollux/lib/anoncreds/src/main/scala/io/iohk/atala/pollux/anoncreds/AnoncredLib.scala

pollux/lib/core/src/main/scala/io/iohk/atala/pollux/core/service/CredentialServiceImpl.scala

pollux/lib/core/src/main/scala/io/iohk/atala/pollux/core/service/PresentationServiceImpl.scala

...ib/sql-doobie/src/main/resources/sql/pollux/V17__add_anoncred_credentials_to_use_columns.sql

yshyn-iohk

Great job, @CryptoKnightIOG! You can merge this PR, but I have some concerns about how the tables are being extended for the present proof protocol with specific fields for anoncreds.
Would be nice to discuss this at AoH meeting.
CC: @bvoiturier

ghost · 2024-01-25T15:55:32Z

@CryptoKnightIOG - could you drop an update on this PR for if we plan to move forward with it or abandon it? Thanks!

Signed-off-by: Bassam Riman <[email protected]>

Signed-off-by: Benjamin Voiturier <[email protected]> Signed-off-by: Bassam Riman <[email protected]>

Signed-off-by: Bassam Riman <[email protected]>

sonarcloud · 2024-02-28T03:21:41Z

Quality Gate passed

Issues
42 New issues

Measures
0 Security Hotspots
No data about Coverage
2.2% Duplication on New Code

See analysis details on SonarCloud

# [1.29.0](prism-agent-v1.28.0...prism-agent-v1.29.0) (2024-02-28) ### Bug Fixes * correct the config environment variable name ([#905](#905)) ([d86436c](d86436c)) ### Features * ZKP verification ([#792](#792)) ([ab1ab64](ab1ab64)) Signed-off-by: Anton Baliasnikov <[email protected]>

# [1.29.0](prism-agent-v1.28.0...prism-agent-v1.29.0) (2024-02-28) ### Bug Fixes * correct the config environment variable name ([#905](#905)) ([d86436c](d86436c)) ### Features * ZKP verification ([#792](#792)) ([ab1ab64](ab1ab64)) Signed-off-by: Anton Baliasnikov <[email protected]> Signed-off-by: MICHAEL BREUNINGER <[email protected]>

Signed-off-by: Bassam Riman <[email protected]> Signed-off-by: Benjamin Voiturier <[email protected]> Co-authored-by: bvoiturier <[email protected]>

# [1.29.0](prism-agent-v1.28.0...prism-agent-v1.29.0) (2024-02-28) ### Bug Fixes * correct the config environment variable name ([#905](#905)) ([d86436c](d86436c)) ### Features * ZKP verification ([#792](#792)) ([ab1ab64](ab1ab64)) Signed-off-by: Anton Baliasnikov <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

Signed-off-by: Bassam Riman <[email protected]> Signed-off-by: Benjamin Voiturier <[email protected]> Co-authored-by: bvoiturier <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

# [1.29.0](prism-agent-v1.28.0...prism-agent-v1.29.0) (2024-02-28) ### Bug Fixes * correct the config environment variable name ([#905](#905)) ([d86436c](d86436c)) ### Features * ZKP verification ([#792](#792)) ([ab1ab64](ab1ab64)) Signed-off-by: Anton Baliasnikov <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

Signed-off-by: Bassam Riman <[email protected]> Signed-off-by: Benjamin Voiturier <[email protected]> Co-authored-by: bvoiturier <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

# [1.29.0](prism-agent-v1.28.0...prism-agent-v1.29.0) (2024-02-28) ### Bug Fixes * correct the config environment variable name ([#905](#905)) ([d86436c](d86436c)) ### Features * ZKP verification ([#792](#792)) ([ab1ab64](ab1ab64)) Signed-off-by: Anton Baliasnikov <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

Signed-off-by: Bassam Riman <[email protected]> Signed-off-by: Benjamin Voiturier <[email protected]> Co-authored-by: bvoiturier <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

# [1.29.0](prism-agent-v1.28.0...prism-agent-v1.29.0) (2024-02-28) ### Bug Fixes * correct the config environment variable name ([#905](#905)) ([d86436c](d86436c)) ### Features * ZKP verification ([#792](#792)) ([ab1ab64](ab1ab64)) Signed-off-by: Anton Baliasnikov <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

Signed-off-by: Bassam Riman <[email protected]> Signed-off-by: Benjamin Voiturier <[email protected]> Co-authored-by: bvoiturier <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

# [1.29.0](prism-agent-v1.28.0...prism-agent-v1.29.0) (2024-02-28) ### Bug Fixes * correct the config environment variable name ([#905](#905)) ([d86436c](d86436c)) ### Features * ZKP verification ([#792](#792)) ([ab1ab64](ab1ab64)) Signed-off-by: Anton Baliasnikov <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

atala-dev added pollux Component: Cloud Agent labels Nov 18, 2023

CryptoKnightIOG force-pushed the feat/ZKP-verification branch from 7e18b6a to 36c83d1 Compare November 20, 2023 14:07

CryptoKnightIOG force-pushed the feat/ZKP-verification branch from 36c83d1 to 5376b74 Compare November 22, 2023 00:06

BS-IO removed the pollux label Nov 28, 2023

CryptoKnightIOG force-pushed the feat/ZKP-verification branch from 1bf9287 to bef9239 Compare November 30, 2023 11:44

atala-dev added pollux prism-agent build labels Nov 30, 2023

CryptoKnightIOG force-pushed the feat/ZKP-verification branch 2 times, most recently from c3fbcd0 to b430d6c Compare December 20, 2023 17:20

CryptoKnightIOG force-pushed the feat/ZKP-verification branch from f115da4 to 3ac1cb8 Compare January 3, 2024 19:26

CryptoKnightIOG marked this pull request as ready for review January 3, 2024 19:27

CryptoKnightIOG requested review from bvoiturier, yshyn-iohk, patlo-iog and mineme0110 as code owners January 3, 2024 19:27

yshyn-iohk reviewed Jan 4, 2024

View reviewed changes

pollux/lib/anoncreds/src/main/scala/io/iohk/atala/pollux/anoncreds/AnoncredLib.scala Show resolved Hide resolved

yshyn-iohk reviewed Jan 4, 2024

View reviewed changes

pollux/lib/core/src/main/scala/io/iohk/atala/pollux/core/service/CredentialServiceImpl.scala Show resolved Hide resolved

yshyn-iohk reviewed Jan 4, 2024

View reviewed changes

pollux/lib/core/src/main/scala/io/iohk/atala/pollux/core/service/PresentationServiceImpl.scala Outdated Show resolved Hide resolved

yshyn-iohk reviewed Jan 4, 2024

View reviewed changes

...ib/sql-doobie/src/main/resources/sql/pollux/V17__add_anoncred_credentials_to_use_columns.sql Show resolved Hide resolved

yshyn-iohk approved these changes Jan 4, 2024

View reviewed changes

CryptoKnightIOG requested a review from antonbaliasnikov as a code owner January 15, 2024 08:13

CryptoKnightIOG force-pushed the feat/ZKP-verification branch from e7e5f57 to f050918 Compare January 24, 2024 18:53

CryptoKnightIOG requested a review from amagyar-iohk as a code owner January 24, 2024 18:53

CryptoKnightIOG changed the title ~~Feat: ZKP verification~~ feat: ZKP verification Jan 30, 2024

CryptoKnightIOG force-pushed the feat/ZKP-verification branch from 015084e to d221554 Compare February 23, 2024 01:00

CryptoKnightIOG and others added 12 commits February 27, 2024 21:38

feat: add serdeser for anoncred presentation request (#768)

3e08c31

Signed-off-by: Bassam Riman <[email protected]>

feat: Create/Store presentation proof request (#774)

94401d1

Signed-off-by: Bassam Riman <[email protected]>

feat: Receive/Store Presentation Request (#776)

ede4d4c

Signed-off-by: Bassam Riman <[email protected]>

feat: Accept Presentation Request (#781)

839ac78

Signed-off-by: Bassam Riman <[email protected]>

feat: Create Store Presentation (#788)

d3d06b4

Signed-off-by: Bassam Riman <[email protected]>

feat: Create & Store Presentation (#794)

0e15763

Signed-off-by: Bassam Riman <[email protected]>

feat: Add Predicate and Attribute through API (#802)

06bc1c8

Signed-off-by: Bassam Riman <[email protected]>

feat: validate presentation (#815)

0f82a2e

Signed-off-by: Bassam Riman <[email protected]>

fix(prism-agent): fix credential schema parsing as spec (#841)

8439de4

Signed-off-by: Benjamin Voiturier <[email protected]> Signed-off-by: Bassam Riman <[email protected]>

feat: interoperable credential definition api (#852)

e16f8d5

Signed-off-by: Bassam Riman <[email protected]>

feat: refactor duplcate code (#873)

d416266

Signed-off-by: Bassam Riman <[email protected]>

feat: Update documentation (#898)

94b0277

Signed-off-by: Bassam Riman <[email protected]>

CryptoKnightIOG force-pushed the feat/ZKP-verification branch from d221554 to 94b0277 Compare February 28, 2024 03:20

CryptoKnightIOG merged commit ab1ab64 into main Feb 28, 2024
18 checks passed

CryptoKnightIOG deleted the feat/ZKP-verification branch February 28, 2024 03:41

shotexa pushed a commit that referenced this pull request Mar 6, 2024

feat: ZKP verification (#792)

26821f1

Signed-off-by: Bassam Riman <[email protected]> Signed-off-by: Benjamin Voiturier <[email protected]> Co-authored-by: bvoiturier <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ZKP verification #792

feat: ZKP verification #792

CryptoKnightIOG commented Nov 18, 2023 •

edited

Loading

github-actions bot commented Nov 18, 2023 •

edited

Loading

github-actions bot commented Nov 18, 2023

github-actions bot commented Nov 20, 2023 •

edited

Loading

yshyn-iohk left a comment

ghost commented Jan 25, 2024

sonarcloud bot commented Feb 28, 2024

feat: ZKP verification #792

feat: ZKP verification #792

Conversation

CryptoKnightIOG commented Nov 18, 2023 • edited Loading

Overview

Checklist

My PR contains...

My changes...

Documentation

Tests

github-actions bot commented Nov 18, 2023 • edited Loading

Integration Test Results

github-actions bot commented Nov 18, 2023

Atala PRISM Test Results

github-actions bot commented Nov 20, 2023 • edited Loading

Unit Test Results

yshyn-iohk left a comment

Choose a reason for hiding this comment

ghost commented Jan 25, 2024

sonarcloud bot commented Feb 28, 2024

Quality Gate passed

CryptoKnightIOG commented Nov 18, 2023 •

edited

Loading

github-actions bot commented Nov 18, 2023 •

edited

Loading

github-actions bot commented Nov 20, 2023 •

edited

Loading