Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(BAE): updating jsMain Ed25519 keys for use in TS #92

Merged
merged 3 commits into from
Oct 3, 2023
Merged

feat(BAE): updating jsMain Ed25519 keys for use in TS #92

merged 3 commits into from
Oct 3, 2023

Conversation

curtis-h
Copy link
Contributor

@curtis-h curtis-h commented Sep 21, 2023 •
edited
Loading

Description

Adding some functionality to jsMain for integration:

  • KMMEdPrivateKey:
    • added publicKey getter
    • added parser to handle encoded or raw values passed to constructor
  • KMMEDKeypair:
    • fixed passing ByteArray into ed25519 lib, which was creating keys with the wrong values
  • KMMEdPublicKey
    • added parser to handle encoded or raw values passed to constructor
    • changed to using hex string with the ed25519 lib, as the Types are broken regarding arrays
  • external/Elliptic
    • changed type from ByteArray to Buffer, as Kotlin ByteArrays are signed and we want unsigned values
  • KMMX25519PrivateKey
    • added getEncoded to retrieve encoded value
    • added publicKey getter
  • KMMX25519PublicKey
    • added getEncoded to retrieve encoded value

Jira link

https://input-output.atlassian.net/browse/ATL-5688

Checklist

  • Self-reviewed the diff
  • New code has inline documentation
  • New code has proper comments/tests
  • Any changes not covered by tests have been tested manually

@curtis-h curtis-h self-assigned this Sep 21, 2023
@curtis-h curtis-h mentioned this pull request Sep 21, 2023
Closed
4 tasks
@atala-dev
Copy link
Contributor

atala-dev commented Sep 21, 2023 •
edited
Loading

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 12 0 0.05s
✅ KOTLIN ktlint 12 0 25.8s
⚠️ REPOSITORY devskim yes 35 3.66s
✅ REPOSITORY dustilock yes no 0.06s
✅ REPOSITORY gitleaks yes no 1.67s
✅ REPOSITORY git_diff yes no 0.05s
✅ REPOSITORY grype yes no 16.04s
⚠️ REPOSITORY kics yes 1 40.31s
✅ REPOSITORY secretlint yes no 3.66s
✅ REPOSITORY syft yes no 0.44s
✅ REPOSITORY trivy yes no 4.27s
✅ REPOSITORY trivy-sbom yes no 1.35s
⚠️ REPOSITORY trufflehog yes 1 5.33s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

hamada147
hamada147 suggested changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@hamada147 hamada147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing implementation of the publicKey method in the KMMEdPrivateKey class for the rest of the supported platforms.

...-asymmetric-encryption/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPrivateKey.kt Outdated Show resolved Hide resolved
base-asymmetric-encryption/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPublicKey.kt Outdated Show resolved Hide resolved
@atala-dev
Copy link
Contributor

atala-dev commented Sep 29, 2023 •
edited
Loading

Code Coverage

File Coverage [87.30%] ❌
base-asymmetric-encryption/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdKeyPair.kt 100.00% ✅
base-asymmetric-encryption/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMX25519KeyPair.kt 100.00% ✅
base-asymmetric-encryption/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdKeyPair.kt 100.00% ✅
base-asymmetric-encryption/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPrivateKey.kt 66.67% ❌
base-asymmetric-encryption/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPublicKey.kt 77.78% ❌
base-asymmetric-encryption/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMX25519KeyPair.kt 100.00% ✅
base-asymmetric-encryption/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMX25519PrivateKey.kt 25.00% ❌
base-asymmetric-encryption/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMX25519PublicKey.kt 100.00% ✅
Total Project Coverage 91.15% ✅

@curtis-h curtis-h force-pushed the feature/ATL-5688 branch 3 times, most recently from 3d26ac1 to 80fcbc0 Compare October 2, 2023 08:13
@cristianIOHK
Copy link
Contributor

cristianIOHK commented Oct 2, 2023 •
edited
Loading

@hamada147 @curtis-h I created another PR where these public key getters are implemented for jvm and android.
#96
It is already merged.

hamada147
hamada147 suggested changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@hamada147 hamada147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Kotlin method and function documentation, we do not add the following line @function "method name". This is only needed on the JS & TS code bases.

...asymmetric-encryption/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/Curve25519Parser.kt Outdated Show resolved Hide resolved
...-asymmetric-encryption/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPrivateKey.kt Outdated Show resolved Hide resolved
...-asymmetric-encryption/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPrivateKey.kt Outdated Show resolved Hide resolved
...-asymmetric-encryption/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPrivateKey.kt Outdated Show resolved Hide resolved
...mmetric-encryption/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMX25519PrivateKey.kt Outdated Show resolved Hide resolved
...mmetric-encryption/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMX25519PrivateKey.kt Outdated Show resolved Hide resolved
...ymmetric-encryption/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMX25519PublicKey.kt Outdated Show resolved Hide resolved
base-asymmetric-encryption/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPublicKey.kt Outdated Show resolved Hide resolved
base-asymmetric-encryption/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPublicKey.kt Outdated Show resolved Hide resolved
@hamada147
Copy link
Contributor

@curtis-h Please merge you branch with the latest so that you get the Linter issue fixed.

@curtis-h curtis-h merged commit c7d3bc1 into main Oct 3, 2023
3 checks passed
@curtis-h curtis-h deleted the feature/ATL-5688 branch October 3, 2023 13:10
elribonazo added a commit that referenced this pull request Oct 4, 2023
@elribonazo
Merge branch 'feature/ATL-5687' of github.com:input-output-hk/atala-p…
0ac9935 
…rism-apollo into feature/ATL-5687

* 'feature/ATL-5687' of github.com:input-output-hk/atala-prism-apollo:
  fix: deployment script (#101)
  build: increase gradle version 1.0.2 (#100)
  feat(BAE): updating jsMain Ed25519 keys for use in TS (#92)
  fix: constructor and access to some methods were missing in ios (#93)
  fix: bugs found while integrating apollo with KMP SDK (#98)
  fix: KMP Gradle bug (#99)
  build: increase gradle version 1.0.1 (#97)
  feature: add publicKey to PrivateKeys (#96)
  feat: compress and uncompress secp256k1 functionality for (macos,ios,js,android,jvm) (#95)
  feat: add mnemonic validation (#94)

# Conflicts:
#	base-asymmetric-encryption/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMECSecp256k1PublicKey.kt
atala-dev added a commit that referenced this pull request Nov 10, 2023
@atala-dev
chore(release): cut apollo version 1.0.0-snapshot.1
31ab5ba 
# 1.0.0-snapshot.1 (2023-11-10)

### Bug Fixes

* Add all the required dependencies for Apollo to build with the native cinterops ios version of secp256k1 ec. ([1ca5b68](1ca5b68))
* add empty changelog ([db7ebee](db7ebee))
* add new line at end of file ([a6ab13c](a6ab13c))
* add new line to build.gradle.kts files ([f84b4e4](f84b4e4))
* BigInteger has no corresponding exportable dataType in JS ([#88](#88)) ([3e636be](3e636be))
* bugs found while integrating apollo with KMP SDK ([#98](#98)) ([de71265](de71265))
* CI nonsense error ([1963ad2](1963ad2))
* ci reported linting issues ([31aee01](31aee01))
* ci wrong reported issues by mega lint ([b6da47a](b6da47a))
* **CI:** Update GitHub Actions script ([#90](#90)) ([e6f6d46](e6f6d46))
* code linting ([94ededd](94ededd))
* code linting errors ([69dfbd1](69dfbd1))
* code linting errors ([9774cbc](9774cbc))
* constructor and access to some methods were missing in ios ([#93](#93)) ([a64d707](a64d707))
* deployment script ([#101](#101)) ([6435bf8](6435bf8))
* disable JS on windows platform ([6a2bfd4](6a2bfd4))
* enforce code format ([39f4474](39f4474))
* enforce code format ([9e946fc](9e946fc))
* enforce code format ([f034d69](f034d69))
* enforce code quality ([3b060dd](3b060dd))
* fix deployment CI script ([4583b2f](4583b2f))
* fix error in git ([85d1965](85d1965))
* fix for issue [#30](#30) ([b1c1a4e](b1c1a4e))
* fix group id ([4a70cd6](4a70cd6))
* fixed wrong import in UUID ([622187b](622187b))
* gradle build script ([b191baa](b191baa))
* HMAC for JS platform ([6ce142c](6ce142c))
* iOS import was removed by mistake ([9994889](9994889))
* js module name ([06e4310](06e4310))
* KMP Gradle bug ([#99](#99)) ([648bcdd](648bcdd))
* linting issue ([7918146](7918146))
* Publish npm package ([#103](#103)) ([81ac735](81ac735))
* **secp256k1:** Exposing EC Secp256K1 ([#89](#89)) ([90a578a](90a578a))
* suppress not needed warnings ([0b800c8](0b800c8))
* test apollo release ([8fd52ff](8fd52ff))

### Features

* add mnemonic validation ([#94](#94)) ([173ad94](173ad94))
* add test dependency ([a6b7b25](a6b7b25))
* add UnsupportedOperationException ([852644d](852644d))
* AES & fixes ([d60cafb](d60cafb))
* AES encryption & decryption ([e4af9ec](e4af9ec))
* Apollo to support all apple devices ([b4c22ed](b4c22ed))
* Apollo to support all apple devices ([355970f](355970f))
* Apollo to support all apple devices ([de6fd03](de6fd03))
* **BAE:** updating jsMain Ed25519 keys for use in TS ([#92](#92)) ([c7d3bc1](c7d3bc1))
* base symmetric key encryption module ([b7fb2a3](b7fb2a3))
* Base16 encoding & decoding ([a6be3b8](a6be3b8))
* Base16 Upper ([85fbbef](85fbbef))
* Base32 ([c0ff1f7](c0ff1f7))
* Base58 ([e4c9602](e4c9602))
* base64 ([f1ddaa3](f1ddaa3))
* base64 module init ([f3311a0](f3311a0))
* **bip32:** add hd derivation for jvm/android, ios/macos and js ([#84](#84)) ([d564507](d564507))
* **bip39:** Add Bip39 implementation for all platforms ([#78](#78)) ([b695878](b695878))
* char ext ([8a68df1](8a68df1))
* compress and uncompress secp256k1 functionality for (macos,ios,js,android,jvm) ([#95](#95)) ([21c33e4](21c33e4))
* Ed25519 ([eb7f52a](eb7f52a))
* **ed25519:** add jvm and android ed25519 implementation ([#85](#85)) ([ee9757d](ee9757d))
* **ED25519:** ED25519 jsMain implementation ([#76](#76)) ([e8945df](e8945df))
* **ed25519:** ios, macos implementation of ed25519 ([#79](#79)) ([a25798c](a25798c))
* **Experience:** add data type helper methods ([c52cd79](c52cd79))
* **Experience:** add transfer between iOS & KMM ([55ccca5](55ccca5))
* **Experience:** platform os ([208a04f](208a04f))
* **Hashing:** add HashingBase for MD and SHA(1,2) ([859b62a](859b62a))
* **Hashing:** add MathHelper ([2e40af9](2e40af9))
* **Hashing:** BLAKE-family Unit tests ([f414634](f414634))
* **Hashing:** BLAKE224 ([f2d658e](f2d658e))
* **Hashing:** BLAKE256 ([0b02aef](0b02aef))
* **Hashing:** BLAKE2B ([a6ed518](a6ed518))
* **Hashing:** BLAKE2B Unit tests ([45de7b6](45de7b6))
* **Hashing:** BLAKE2B-160 ([dacbb57](dacbb57))
* **Hashing:** BLAKE2B-256 ([0ed656d](0ed656d))
* **Hashing:** BLAKE2B-384 ([32d8ce6](32d8ce6))
* **Hashing:** BLAKE2B-512 ([f1d5043](f1d5043))
* **Hashing:** BLAKE2S ([50bb741](50bb741))
* **Hashing:** BLAKE2S Unit tests ([1284bb3](1284bb3))
* **Hashing:** BLAKE2S-128 ([fbf9ed2](fbf9ed2))
* **Hashing:** BLAKE2S-160 ([9a6e6a6](9a6e6a6))
* **Hashing:** BLAKE2S-224 ([dad2561](dad2561))
* **Hashing:** BLAKE2S-256 ([d2c0fc8](d2c0fc8))
* **Hashing:** BLAKE384 ([dc42633](dc42633))
* **Hashing:** BLAKE512 ([2a4e1b5](2a4e1b5))
* **Hashing:** digest interface ([4548aa1](4548aa1))
* **Hashing:** KeccakDigest ([a10f5f2](a10f5f2))
* **Hashing:** MD2 ([803fc73](803fc73))
* **Hashing:** MD4 ([859d26a](859d26a))
* **Hashing:** MD5 ([9f57ce5](9f57ce5))
* **Hashing:** SHA0 ([2469d1d](2469d1d))
* **Hashing:** SHA0 Unit tests ([482b3a9](482b3a9))
* **Hashing:** SHA1 ([f33d1d9](f33d1d9))
* **Hashing:** SHA1 Unit Tests ([b83af38](b83af38))
* **Hashing:** SHA224 ([47534f7](47534f7))
* **Hashing:** SHA224 Unit tests ([59d8751](59d8751))
* **Hashing:** SHA256 ([a12af78](a12af78))
* **Hashing:** SHA256 Unit tests ([c829aab](c829aab))
* **Hashing:** SHA3-224 ([372e5a9](372e5a9))
* **Hashing:** SHA3-256 ([a885989](a885989))
* **Hashing:** SHA3-384 ([2fa5b14](2fa5b14))
* **Hashing:** SHA3-512 ([e45543e](e45543e))
* **Hashing:** SHA3-family Unit tests ([ac535d2](ac535d2))
* **Hashing:** SHA384 ([207a58e](207a58e))
* **Hashing:** SHA384 Unit tests ([09ec034](09ec034))
* **Hashing:** SHA512 ([a9d10bf](a9d10bf))
* **Hashing:** SHA512 Unit tests ([c567ff7](c567ff7))
* **Hashing:** SHA512/224 ([192b205](192b205))
* **Hashing:** SHA512/224 Unit test ([62a2ede](62a2ede))
* **Hashing:** SHA512/256 ([6ddd004](6ddd004))
* **Hashing:** SHA512/256 Unit test ([24450a4](24450a4))
* Long ext ([fe5e1cf](fe5e1cf))
* **MAC:** HMAC implementation ([935d9c2](935d9c2))
* **mnemonic:** js doesnt handle List and swift doesnt handle Array this is the solution ([#105](#105)) ([e65e0f0](e65e0f0))
* multibase ([73a1e7b](73a1e7b))
* NumberFormatException ext ([8955561](8955561))
* **secp256k1:** add library to be our dependency for secp256k1 in android, jvm, ios, macos, js ([3e41246](3e41246))
* Secure Random ([e577736](e577736))
* Utils module ([ba7eefb](ba7eefb))
* UUID ([85afcb8](85afcb8))
* UUID init ([a1d9b65](a1d9b65))
* x25519 key pair generation ([4227c2c](4227c2c))
* **x25519:** add x25519 implementation for ios, macos ([#80](#80)) ([c18c0eb](c18c0eb))
atala-dev added a commit that referenced this pull request Nov 13, 2023
@atala-dev
chore(release): cut apollo version 1.0.0
d8ab651 
# 1.0.0 (2023-11-13)

### Bug Fixes

* Add all the required dependencies for Apollo to build with the native cinterops ios version of secp256k1 ec. ([1ca5b68](1ca5b68))
* add new line at end of file ([a6ab13c](a6ab13c))
* add new line to build.gradle.kts files ([f84b4e4](f84b4e4))
* BigInteger has no corresponding exportable dataType in JS ([#88](#88)) ([3e636be](3e636be))
* bugs found while integrating apollo with KMP SDK ([#98](#98)) ([de71265](de71265))
* CI nonsense error ([1963ad2](1963ad2))
* ci reported linting issues ([31aee01](31aee01))
* ci wrong reported issues by mega lint ([b6da47a](b6da47a))
* **CI:** Update GitHub Actions script ([#90](#90)) ([e6f6d46](e6f6d46))
* code linting ([94ededd](94ededd))
* code linting errors ([69dfbd1](69dfbd1))
* code linting errors ([9774cbc](9774cbc))
* constructor and access to some methods were missing in ios ([#93](#93)) ([a64d707](a64d707))
* deployment script ([#101](#101)) ([6435bf8](6435bf8))
* disable JS on windows platform ([6a2bfd4](6a2bfd4))
* enforce code format ([39f4474](39f4474))
* enforce code format ([9e946fc](9e946fc))
* enforce code format ([f034d69](f034d69))
* enforce code quality ([3b060dd](3b060dd))
* fix deployment CI script ([4583b2f](4583b2f))
* fix error in git ([85d1965](85d1965))
* fix for issue [#30](#30) ([b1c1a4e](b1c1a4e))
* fix group id ([4a70cd6](4a70cd6))
* fixed wrong import in UUID ([622187b](622187b))
* gradle build script ([b191baa](b191baa))
* HMAC for JS platform ([6ce142c](6ce142c))
* iOS import was removed by mistake ([9994889](9994889))
* js module name ([06e4310](06e4310))
* KMP Gradle bug ([#99](#99)) ([648bcdd](648bcdd))
* linting issue ([7918146](7918146))
* Publish npm package ([#103](#103)) ([81ac735](81ac735))
* **secp256k1:** Exposing EC Secp256K1 ([#89](#89)) ([90a578a](90a578a))
* suppress not needed warnings ([0b800c8](0b800c8))

### Features

* add mnemonic validation ([#94](#94)) ([173ad94](173ad94))
* add test dependency ([a6b7b25](a6b7b25))
* add UnsupportedOperationException ([852644d](852644d))
* AES & fixes ([d60cafb](d60cafb))
* AES encryption & decryption ([e4af9ec](e4af9ec))
* Apollo to support all apple devices ([b4c22ed](b4c22ed))
* Apollo to support all apple devices ([355970f](355970f))
* Apollo to support all apple devices ([de6fd03](de6fd03))
* **BAE:** updating jsMain Ed25519 keys for use in TS ([#92](#92)) ([c7d3bc1](c7d3bc1))
* base symmetric key encryption module ([b7fb2a3](b7fb2a3))
* Base16 encoding & decoding ([a6be3b8](a6be3b8))
* Base16 Upper ([85fbbef](85fbbef))
* Base32 ([c0ff1f7](c0ff1f7))
* Base58 ([e4c9602](e4c9602))
* base64 ([f1ddaa3](f1ddaa3))
* base64 module init ([f3311a0](f3311a0))
* **bip32:** add hd derivation for jvm/android, ios/macos and js ([#84](#84)) ([d564507](d564507))
* **bip39:** Add Bip39 implementation for all platforms ([#78](#78)) ([b695878](b695878))
* char ext ([8a68df1](8a68df1))
* compress and uncompress secp256k1 functionality for (macos,ios,js,android,jvm) ([#95](#95)) ([21c33e4](21c33e4))
* Ed25519 ([eb7f52a](eb7f52a))
* **ed25519:** add jvm and android ed25519 implementation ([#85](#85)) ([ee9757d](ee9757d))
* **ED25519:** ED25519 jsMain implementation ([#76](#76)) ([e8945df](e8945df))
* **ed25519:** ios, macos implementation of ed25519 ([#79](#79)) ([a25798c](a25798c))
* **Experience:** add data type helper methods ([c52cd79](c52cd79))
* **Experience:** add transfer between iOS & KMM ([55ccca5](55ccca5))
* **Experience:** platform os ([208a04f](208a04f))
* **Hashing:** add HashingBase for MD and SHA(1,2) ([859b62a](859b62a))
* **Hashing:** add MathHelper ([2e40af9](2e40af9))
* **Hashing:** BLAKE-family Unit tests ([f414634](f414634))
* **Hashing:** BLAKE224 ([f2d658e](f2d658e))
* **Hashing:** BLAKE256 ([0b02aef](0b02aef))
* **Hashing:** BLAKE2B ([a6ed518](a6ed518))
* **Hashing:** BLAKE2B Unit tests ([45de7b6](45de7b6))
* **Hashing:** BLAKE2B-160 ([dacbb57](dacbb57))
* **Hashing:** BLAKE2B-256 ([0ed656d](0ed656d))
* **Hashing:** BLAKE2B-384 ([32d8ce6](32d8ce6))
* **Hashing:** BLAKE2B-512 ([f1d5043](f1d5043))
* **Hashing:** BLAKE2S ([50bb741](50bb741))
* **Hashing:** BLAKE2S Unit tests ([1284bb3](1284bb3))
* **Hashing:** BLAKE2S-128 ([fbf9ed2](fbf9ed2))
* **Hashing:** BLAKE2S-160 ([9a6e6a6](9a6e6a6))
* **Hashing:** BLAKE2S-224 ([dad2561](dad2561))
* **Hashing:** BLAKE2S-256 ([d2c0fc8](d2c0fc8))
* **Hashing:** BLAKE384 ([dc42633](dc42633))
* **Hashing:** BLAKE512 ([2a4e1b5](2a4e1b5))
* **Hashing:** digest interface ([4548aa1](4548aa1))
* **Hashing:** KeccakDigest ([a10f5f2](a10f5f2))
* **Hashing:** MD2 ([803fc73](803fc73))
* **Hashing:** MD4 ([859d26a](859d26a))
* **Hashing:** MD5 ([9f57ce5](9f57ce5))
* **Hashing:** SHA0 ([2469d1d](2469d1d))
* **Hashing:** SHA0 Unit tests ([482b3a9](482b3a9))
* **Hashing:** SHA1 ([f33d1d9](f33d1d9))
* **Hashing:** SHA1 Unit Tests ([b83af38](b83af38))
* **Hashing:** SHA224 ([47534f7](47534f7))
* **Hashing:** SHA224 Unit tests ([59d8751](59d8751))
* **Hashing:** SHA256 ([a12af78](a12af78))
* **Hashing:** SHA256 Unit tests ([c829aab](c829aab))
* **Hashing:** SHA3-224 ([372e5a9](372e5a9))
* **Hashing:** SHA3-256 ([a885989](a885989))
* **Hashing:** SHA3-384 ([2fa5b14](2fa5b14))
* **Hashing:** SHA3-512 ([e45543e](e45543e))
* **Hashing:** SHA3-family Unit tests ([ac535d2](ac535d2))
* **Hashing:** SHA384 ([207a58e](207a58e))
* **Hashing:** SHA384 Unit tests ([09ec034](09ec034))
* **Hashing:** SHA512 ([a9d10bf](a9d10bf))
* **Hashing:** SHA512 Unit tests ([c567ff7](c567ff7))
* **Hashing:** SHA512/224 ([192b205](192b205))
* **Hashing:** SHA512/224 Unit test ([62a2ede](62a2ede))
* **Hashing:** SHA512/256 ([6ddd004](6ddd004))
* **Hashing:** SHA512/256 Unit test ([24450a4](24450a4))
* Long ext ([fe5e1cf](fe5e1cf))
* **MAC:** HMAC implementation ([935d9c2](935d9c2))
* **mnemonic:** js doesnt handle List and swift doesnt handle Array this is the solution ([#105](#105)) ([e65e0f0](e65e0f0))
* multibase ([73a1e7b](73a1e7b))
* NumberFormatException ext ([8955561](8955561))
* **secp256k1:** add library to be our dependency for secp256k1 in android, jvm, ios, macos, js ([3e41246](3e41246))
* Secure Random ([e577736](e577736))
* Utils module ([ba7eefb](ba7eefb))
* UUID ([85afcb8](85afcb8))
* UUID init ([a1d9b65](a1d9b65))
* x25519 key pair generation ([4227c2c](4227c2c))
* **x25519:** add x25519 implementation for ios, macos ([#80](#80)) ([c18c0eb](c18c0eb))
hamada147 added a commit that referenced this pull request May 20, 2024
@curtis-h @hamada147
feat(BAE): updating jsMain Ed25519 keys for use in TS (#92)
fba402c 
Co-authored-by: Ahmed Moussa <[email protected]>
Signed-off-by: Curtis <[email protected]>
hamada147 pushed a commit that referenced this pull request May 20, 2024
@atala-dev @hamada147
chore(release): cut apollo version 1.0.0
69bd7e9 
# 1.0.0 (2023-11-13)

### Bug Fixes

* Add all the required dependencies for Apollo to build with the native cinterops ios version of secp256k1 ec. ([1ca5b68](1ca5b68))
* add new line at end of file ([a6ab13c](a6ab13c))
* add new line to build.gradle.kts files ([f84b4e4](f84b4e4))
* BigInteger has no corresponding exportable dataType in JS ([#88](#88)) ([3e636be](3e636be))
* bugs found while integrating apollo with KMP SDK ([#98](#98)) ([de71265](de71265))
* CI nonsense error ([1963ad2](1963ad2))
* ci reported linting issues ([31aee01](31aee01))
* ci wrong reported issues by mega lint ([b6da47a](b6da47a))
* **CI:** Update GitHub Actions script ([#90](#90)) ([e6f6d46](e6f6d46))
* code linting ([94ededd](94ededd))
* code linting errors ([69dfbd1](69dfbd1))
* code linting errors ([9774cbc](9774cbc))
* constructor and access to some methods were missing in ios ([#93](#93)) ([a64d707](a64d707))
* deployment script ([#101](#101)) ([6435bf8](6435bf8))
* disable JS on windows platform ([6a2bfd4](6a2bfd4))
* enforce code format ([39f4474](39f4474))
* enforce code format ([9e946fc](9e946fc))
* enforce code format ([f034d69](f034d69))
* enforce code quality ([3b060dd](3b060dd))
* fix deployment CI script ([4583b2f](4583b2f))
* fix error in git ([85d1965](85d1965))
* fix for issue [#30](#30) ([b1c1a4e](b1c1a4e))
* fix group id ([4a70cd6](4a70cd6))
* fixed wrong import in UUID ([622187b](622187b))
* gradle build script ([b191baa](b191baa))
* HMAC for JS platform ([6ce142c](6ce142c))
* iOS import was removed by mistake ([9994889](9994889))
* js module name ([06e4310](06e4310))
* KMP Gradle bug ([#99](#99)) ([648bcdd](648bcdd))
* linting issue ([7918146](7918146))
* Publish npm package ([#103](#103)) ([81ac735](81ac735))
* **secp256k1:** Exposing EC Secp256K1 ([#89](#89)) ([90a578a](90a578a))
* suppress not needed warnings ([0b800c8](0b800c8))

### Features

* add mnemonic validation ([#94](#94)) ([173ad94](173ad94))
* add test dependency ([a6b7b25](a6b7b25))
* add UnsupportedOperationException ([852644d](852644d))
* AES & fixes ([d60cafb](d60cafb))
* AES encryption & decryption ([e4af9ec](e4af9ec))
* Apollo to support all apple devices ([b4c22ed](b4c22ed))
* Apollo to support all apple devices ([355970f](355970f))
* Apollo to support all apple devices ([de6fd03](de6fd03))
* **BAE:** updating jsMain Ed25519 keys for use in TS ([#92](#92)) ([c7d3bc1](c7d3bc1))
* base symmetric key encryption module ([b7fb2a3](b7fb2a3))
* Base16 encoding & decoding ([a6be3b8](a6be3b8))
* Base16 Upper ([85fbbef](85fbbef))
* Base32 ([c0ff1f7](c0ff1f7))
* Base58 ([e4c9602](e4c9602))
* base64 ([f1ddaa3](f1ddaa3))
* base64 module init ([f3311a0](f3311a0))
* **bip32:** add hd derivation for jvm/android, ios/macos and js ([#84](#84)) ([d564507](d564507))
* **bip39:** Add Bip39 implementation for all platforms ([#78](#78)) ([b695878](b695878))
* char ext ([8a68df1](8a68df1))
* compress and uncompress secp256k1 functionality for (macos,ios,js,android,jvm) ([#95](#95)) ([21c33e4](21c33e4))
* Ed25519 ([eb7f52a](eb7f52a))
* **ed25519:** add jvm and android ed25519 implementation ([#85](#85)) ([ee9757d](ee9757d))
* **ED25519:** ED25519 jsMain implementation ([#76](#76)) ([e8945df](e8945df))
* **ed25519:** ios, macos implementation of ed25519 ([#79](#79)) ([a25798c](a25798c))
* **Experience:** add data type helper methods ([c52cd79](c52cd79))
* **Experience:** add transfer between iOS & KMM ([55ccca5](55ccca5))
* **Experience:** platform os ([208a04f](208a04f))
* **Hashing:** add HashingBase for MD and SHA(1,2) ([859b62a](859b62a))
* **Hashing:** add MathHelper ([2e40af9](2e40af9))
* **Hashing:** BLAKE-family Unit tests ([f414634](f414634))
* **Hashing:** BLAKE224 ([f2d658e](f2d658e))
* **Hashing:** BLAKE256 ([0b02aef](0b02aef))
* **Hashing:** BLAKE2B ([a6ed518](a6ed518))
* **Hashing:** BLAKE2B Unit tests ([45de7b6](45de7b6))
* **Hashing:** BLAKE2B-160 ([dacbb57](dacbb57))
* **Hashing:** BLAKE2B-256 ([0ed656d](0ed656d))
* **Hashing:** BLAKE2B-384 ([32d8ce6](32d8ce6))
* **Hashing:** BLAKE2B-512 ([f1d5043](f1d5043))
* **Hashing:** BLAKE2S ([50bb741](50bb741))
* **Hashing:** BLAKE2S Unit tests ([1284bb3](1284bb3))
* **Hashing:** BLAKE2S-128 ([fbf9ed2](fbf9ed2))
* **Hashing:** BLAKE2S-160 ([9a6e6a6](9a6e6a6))
* **Hashing:** BLAKE2S-224 ([dad2561](dad2561))
* **Hashing:** BLAKE2S-256 ([d2c0fc8](d2c0fc8))
* **Hashing:** BLAKE384 ([dc42633](dc42633))
* **Hashing:** BLAKE512 ([2a4e1b5](2a4e1b5))
* **Hashing:** digest interface ([4548aa1](4548aa1))
* **Hashing:** KeccakDigest ([a10f5f2](a10f5f2))
* **Hashing:** MD2 ([803fc73](803fc73))
* **Hashing:** MD4 ([859d26a](859d26a))
* **Hashing:** MD5 ([9f57ce5](9f57ce5))
* **Hashing:** SHA0 ([2469d1d](2469d1d))
* **Hashing:** SHA0 Unit tests ([482b3a9](482b3a9))
* **Hashing:** SHA1 ([f33d1d9](f33d1d9))
* **Hashing:** SHA1 Unit Tests ([b83af38](b83af38))
* **Hashing:** SHA224 ([47534f7](47534f7))
* **Hashing:** SHA224 Unit tests ([59d8751](59d8751))
* **Hashing:** SHA256 ([a12af78](a12af78))
* **Hashing:** SHA256 Unit tests ([c829aab](c829aab))
* **Hashing:** SHA3-224 ([372e5a9](372e5a9))
* **Hashing:** SHA3-256 ([a885989](a885989))
* **Hashing:** SHA3-384 ([2fa5b14](2fa5b14))
* **Hashing:** SHA3-512 ([e45543e](e45543e))
* **Hashing:** SHA3-family Unit tests ([ac535d2](ac535d2))
* **Hashing:** SHA384 ([207a58e](207a58e))
* **Hashing:** SHA384 Unit tests ([09ec034](09ec034))
* **Hashing:** SHA512 ([a9d10bf](a9d10bf))
* **Hashing:** SHA512 Unit tests ([c567ff7](c567ff7))
* **Hashing:** SHA512/224 ([192b205](192b205))
* **Hashing:** SHA512/224 Unit test ([62a2ede](62a2ede))
* **Hashing:** SHA512/256 ([6ddd004](6ddd004))
* **Hashing:** SHA512/256 Unit test ([24450a4](24450a4))
* Long ext ([fe5e1cf](fe5e1cf))
* **MAC:** HMAC implementation ([935d9c2](935d9c2))
* **mnemonic:** js doesnt handle List and swift doesnt handle Array this is the solution ([#105](#105)) ([e65e0f0](e65e0f0))
* multibase ([73a1e7b](73a1e7b))
* NumberFormatException ext ([8955561](8955561))
* **secp256k1:** add library to be our dependency for secp256k1 in android, jvm, ios, macos, js ([3e41246](3e41246))
* Secure Random ([e577736](e577736))
* Utils module ([ba7eefb](ba7eefb))
* UUID ([85afcb8](85afcb8))
* UUID init ([a1d9b65](a1d9b65))
* x25519 key pair generation ([4227c2c](4227c2c))
* **x25519:** add x25519 implementation for ios, macos ([#80](#80)) ([c18c0eb](c18c0eb))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamada147 hamada147 hamada147 approved these changes

@elribonazo elribonazo Awaiting requested review from elribonazo

@goncalo-frade-iohk goncalo-frade-iohk Awaiting requested review from goncalo-frade-iohk

@cristianIOHK cristianIOHK Awaiting requested review from cristianIOHK

Assignees

@curtis-h curtis-h

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@curtis-h @atala-dev @cristianIOHK @hamada147