Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest versions for v0.5.0 using FireFly v1.0.0 #38

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

onelapahead
Copy link
Contributor

Also contains configurable certificate expiry related to #37

Copy link
Contributor

@drewmarshburn drewmarshburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for knocking out the cert duration as well.

@@ -41,6 +41,9 @@ spec:
usages:
- server auth
- client auth
{{- if .Values.dataexchange.certificate.duration }}
duration: {{ .Values.dataexchange.certificate.duration | quote }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that was easier than anticipated!

Signed-off-by: hfuss <[email protected]>
@onelapahead onelapahead merged commit 417c3bf into hyperledger:main Apr 13, 2022
@onelapahead onelapahead deleted the ff-v1.0.0 branch April 13, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants